From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: lee.jones@linaro.org, broonie@kernel.org
Cc: sameo@linux.intel.com, lgirdwood@gmail.com,
patches@opensource.wolfsonmicro.com,
linux-kernel@vger.kernel.org
Subject: [PATCH 1/5] mfd: arizona: Factor out SYSCLK enable from wm5102 hardware patch
Date: Mon, 16 Mar 2015 16:58:40 +0000 [thread overview]
Message-ID: <1426525124-12317-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> (raw)
wm5102 applies a custom hardware boot sequence, for this the SYSCLK
needs to be enabled. This patch factors out the code that enables
SYSCLK for this sequence such that it can be used for other boot time
operations that require SYSCLK.
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
drivers/mfd/arizona-core.c | 48 ++++++++++++++++++++++++++++---------------
1 files changed, 31 insertions(+), 17 deletions(-)
diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
index 6ca6dfa..ef1f8aa 100644
--- a/drivers/mfd/arizona-core.c
+++ b/drivers/mfd/arizona-core.c
@@ -250,7 +250,8 @@ static int arizona_wait_for_boot(struct arizona *arizona)
return ret;
}
-static int arizona_apply_hardware_patch(struct arizona* arizona)
+static int arizona_exec_with_sysclk(struct arizona *arizona,
+ int (*exec)(struct arizona *))
{
unsigned int fll, sysclk;
int ret, err;
@@ -292,23 +293,8 @@ static int arizona_apply_hardware_patch(struct arizona* arizona)
goto err_fll;
}
- /* Start the write sequencer and wait for it to finish */
- ret = regmap_write(arizona->regmap, ARIZONA_WRITE_SEQUENCER_CTRL_0,
- ARIZONA_WSEQ_ENA | ARIZONA_WSEQ_START | 160);
- if (ret != 0) {
- dev_err(arizona->dev, "Failed to start write sequencer: %d\n",
- ret);
- goto err_sysclk;
- }
- ret = arizona_poll_reg(arizona, 5, ARIZONA_WRITE_SEQUENCER_CTRL_1,
- ARIZONA_WSEQ_BUSY, 0);
- if (ret != 0) {
- regmap_write(arizona->regmap, ARIZONA_WRITE_SEQUENCER_CTRL_0,
- ARIZONA_WSEQ_ABORT);
- ret = -ETIMEDOUT;
- }
+ ret = exec(arizona);
-err_sysclk:
err = regmap_write(arizona->regmap, ARIZONA_SYSTEM_CLOCK_1, sysclk);
if (err != 0) {
dev_err(arizona->dev,
@@ -330,6 +316,34 @@ err_fll:
return err;
}
+static int arizona_hardware_patch_wseq(struct arizona *arizona)
+{
+ int ret;
+
+ /* Start the write sequencer and wait for it to finish */
+ ret = regmap_write(arizona->regmap, ARIZONA_WRITE_SEQUENCER_CTRL_0,
+ ARIZONA_WSEQ_ENA | ARIZONA_WSEQ_START | 160);
+ if (ret != 0) {
+ dev_err(arizona->dev, "Failed to start write sequencer: %d\n",
+ ret);
+ return ret;
+ }
+ ret = arizona_poll_reg(arizona, 5, ARIZONA_WRITE_SEQUENCER_CTRL_1,
+ ARIZONA_WSEQ_BUSY, 0);
+ if (ret != 0) {
+ regmap_write(arizona->regmap, ARIZONA_WRITE_SEQUENCER_CTRL_0,
+ ARIZONA_WSEQ_ABORT);
+ ret = -ETIMEDOUT;
+ }
+
+ return ret;
+}
+
+static inline int arizona_apply_hardware_patch(struct arizona *arizona)
+{
+ return arizona_exec_with_sysclk(arizona, arizona_hardware_patch_wseq);
+}
+
#ifdef CONFIG_PM
static int arizona_runtime_resume(struct device *dev)
{
--
1.7.2.5
next reply other threads:[~2015-03-16 17:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 16:58 Charles Keepax [this message]
2015-03-16 16:58 ` [PATCH 2/5] mfd: wm5110: Add register patch required for low power sleep Charles Keepax
2015-03-16 16:58 ` [PATCH 3/5] mfd: wm5110: Add delay before releasing reset line on cold boot Charles Keepax
2015-03-16 17:12 ` Mark Brown
2015-03-16 18:45 ` Charles Keepax
2015-03-16 20:47 ` Mark Brown
2015-03-17 11:50 ` Charles Keepax
2015-03-17 12:04 ` Mark Brown
2015-03-17 13:01 ` Charles Keepax
2015-03-16 16:58 ` [PATCH 4/5] regulator: arizona-ldo1: Add additional supported voltage Charles Keepax
2015-03-16 17:18 ` Mark Brown
2015-03-16 16:58 ` [PATCH 5/5] mfd: wm5110: Set DCVDD voltage to 1.175V before entering sleep mode Charles Keepax
2015-03-16 17:17 ` Mark Brown
2015-03-16 18:28 ` Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426525124-12317-1-git-send-email-ckeepax@opensource.wolfsonmicro.com \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=broonie@kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox