From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932118AbbCQARL (ORCPT ); Mon, 16 Mar 2015 20:17:11 -0400 Received: from smtprelay0173.hostedemail.com ([216.40.44.173]:50123 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753402AbbCQARH (ORCPT ); Mon, 16 Mar 2015 20:17:07 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:960:967:973:981:982:988:989:1260:1263:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2525:2561:2564:2612:2682:2685:2693:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:2975:3000:3022:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:5007:6261:8985:9025:9388:10004:10400:10848:11232:11256:11257:11473:11658:11854:11914:12043:12517:12519:12740:13069:13161:13229:13255:13311:13357:13848:14094:14106:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: self87_3dd57f068f161 X-Filterd-Recvd-Size: 2003 Message-ID: <1426551423.23897.40.camel@perches.com> Subject: Re: [PATCH v3 1/6] staging: rtl8192e: fix coding style issues (merge broken strings) From: Joe Perches To: Mateusz Kulikowski Cc: gregkh@linuxfoundation.org, mdcasey@chabloom.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Mon, 16 Mar 2015 17:17:03 -0700 In-Reply-To: <550751E7.30503@gmail.com> References: <1426204401-20414-1-git-send-email-mateusz.kulikowski@gmail.com> <1426204401-20414-2-git-send-email-mateusz.kulikowski@gmail.com> <1426206426.9314.4.camel@perches.com> <550751E7.30503@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-03-16 at 22:57 +0100, Mateusz Kulikowski wrote: > On 13.03.2015 01:27, Joe Perches wrote: > > > > Another thing you might consider is to change these > > embedded function names in another patch to use > > "%s: ", __func__ > > > > RT_TRACE(COMP_ERR, > > "%s: "unknown hardware version\n", > > __func__) > > > > There's a cocci script for that. > > http://cocci.systeme.lip6.narkive.com/nKXf6Bmy/finding-embedded-function-names > > This tool (coccinelle) looks great - I will once take look at it and do swap like suggested; > It probably can be used to cleanup other parts of this driver as well - if I knew about it earlier it would save me a lot of repetitive work. Coccinelle is a very useful tool. Another thing that can save typing is using scripts/checkpatch.pl with the --fix (or --fix-inplace) option with various --types=. There is a trivial script that can help https://lkml.org/lkml/2014/7/11/794