From: Paul Bolle <pebolle@tiscali.nl>
To: Tony Lindgren <tony@atomide.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
linux-omap@vger.kernel.org, Bin Liu <binmlist@gmail.com>,
Brian Hutchinson <b.hutchman@gmail.com>,
Felipe Balbi <balbi@ti.com>,
Matthijs van Duin <matthijsvanduin@gmail.com>,
Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH v2] phy: Add a driver for dm816x USB PHY
Date: Wed, 18 Mar 2015 12:13:31 +0100 [thread overview]
Message-ID: <1426677211.15575.27.camel@x220> (raw)
In-Reply-To: <1426637554-27178-1-git-send-email-tony@atomide.com>
Two trivialities I failed the spot the first time.
On Tue, 2015-03-17 at 17:12 -0700, Tony Lindgren wrote:
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index 2962de2..c858c2b 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> +config PHY_DM816X_USB
> + tristate "TI dm816x USB PHY driver"
> + depends on ARCH_OMAP2PLUS
> + select GENERIC_PHY
> + help
> + Enable this for dm81xx USB to work."
> +
A trailing double quote.
> --- /dev/null
> +++ b/drivers/phy/phy-dm816x-usb.c
> +MODULE_ALIAS("platform: dm816x_usb");
That space looks odd. Will it be removed by scripts/mod/file2alias.c? Or
will it end up in the mdule, in modules.alias, and presumably break
something (I'm not sure what, actually)?
There are currently six other instances MODULE_ALIAS() that have a space
there. That would mean they're all broken, somehow, which would be
unlikely, so I guess it's just a stylistic nit.
Paul Bolle
next prev parent reply other threads:[~2015-03-18 11:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 0:12 [PATCH v2] phy: Add a driver for dm816x USB PHY Tony Lindgren
2015-03-18 11:13 ` Paul Bolle [this message]
2015-03-18 14:56 ` Tony Lindgren
2015-03-18 15:07 ` Kishon Vijay Abraham I
2015-03-18 15:26 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426677211.15575.27.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=b.hutchman@gmail.com \
--cc=balbi@ti.com \
--cc=binmlist@gmail.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthijsvanduin@gmail.com \
--cc=rusty@rustcorp.com.au \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox