linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	David Cohen <david.a.cohen@linux.intel.com>,
	Stephen Boyd <sboyd@codeaurora.org>,
	Baolu Lu <baolu.lu@linux.intel.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCHv2 06/12] usb: dwc3: soft reset to it's own function
Date: Wed, 18 Mar 2015 14:40:27 +0200	[thread overview]
Message-ID: <1426682433-133813-7-git-send-email-heikki.krogerus@linux.intel.com> (raw)
In-Reply-To: <1426682433-133813-1-git-send-email-heikki.krogerus@linux.intel.com>

So it can be called from other places later.

Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
---
 drivers/usb/dwc3/core.c | 46 ++++++++++++++++++++++++++++++----------------
 1 file changed, 30 insertions(+), 16 deletions(-)

diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 104b236..921f181 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -117,6 +117,33 @@ static int dwc3_core_soft_reset(struct dwc3 *dwc)
 }
 
 /**
+ * dwc3_soft_reset - Issue soft reset
+ * @dwc: Pointer to our controller context structure
+ */
+static int dwc3_soft_reset(struct dwc3 *dwc)
+{
+	unsigned long timeout;
+	u32 reg;
+
+	timeout = jiffies + msecs_to_jiffies(500);
+	dwc3_writel(dwc->regs, DWC3_DCTL, DWC3_DCTL_CSFTRST);
+	do {
+		reg = dwc3_readl(dwc->regs, DWC3_DCTL);
+		if (!(reg & DWC3_DCTL_CSFTRST))
+			break;
+
+		if (time_after(jiffies, timeout)) {
+			dev_err(dwc->dev, "Reset Timed Out\n");
+			return -ETIMEDOUT;
+		}
+
+		cpu_relax();
+	} while (true);
+
+	return 0;
+}
+
+/**
  * dwc3_free_one_event_buffer - Frees one event buffer
  * @dwc: Pointer to our controller context structure
  * @evt: Pointer to event buffer to be freed
@@ -438,7 +465,6 @@ static void dwc3_phy_setup(struct dwc3 *dwc)
  */
 static int dwc3_core_init(struct dwc3 *dwc)
 {
-	unsigned long		timeout;
 	u32			hwparams4 = dwc->hwparams.hwparams4;
 	u32			reg;
 	int			ret;
@@ -466,21 +492,9 @@ static int dwc3_core_init(struct dwc3 *dwc)
 	}
 
 	/* issue device SoftReset too */
-	timeout = jiffies + msecs_to_jiffies(500);
-	dwc3_writel(dwc->regs, DWC3_DCTL, DWC3_DCTL_CSFTRST);
-	do {
-		reg = dwc3_readl(dwc->regs, DWC3_DCTL);
-		if (!(reg & DWC3_DCTL_CSFTRST))
-			break;
-
-		if (time_after(jiffies, timeout)) {
-			dev_err(dwc->dev, "Reset Timed Out\n");
-			ret = -ETIMEDOUT;
-			goto err0;
-		}
-
-		cpu_relax();
-	} while (true);
+	ret = dwc3_soft_reset(dwc);
+	if (ret)
+		goto err0;
 
 	ret = dwc3_core_soft_reset(dwc);
 	if (ret)
-- 
2.1.4


  parent reply	other threads:[~2015-03-18 12:41 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-18 12:40 [PATCHv2 00/12] usb: ulpi bus Heikki Krogerus
2015-03-18 12:40 ` [PATCHv2 01/12] usb: add bus type for USB ULPI Heikki Krogerus
2015-03-18 23:26   ` Paul Bolle
2015-03-19 11:44     ` Heikki Krogerus
2015-03-20 12:20       ` [PATCHv3 " Heikki Krogerus
2015-03-26 14:02         ` [PATCHv4 " Heikki Krogerus
2015-03-23  7:16   ` [PATCHv2 " Lu, Baolu
2015-03-23 10:57     ` Heikki Krogerus
2015-03-18 12:40 ` [PATCHv2 02/12] usb: dwc3: USB2 PHY register access bits Heikki Krogerus
2015-03-18 12:40 ` [PATCHv2 03/12] usb: dwc3: ULPI or UTMI+ select Heikki Krogerus
2015-03-18 12:40 ` [PATCHv2 04/12] usb: dwc3: store driver data earlier Heikki Krogerus
2015-03-18 12:40 ` [PATCHv2 05/12] usb: dwc3: cache hwparams earlier Heikki Krogerus
2015-03-18 12:40 ` Heikki Krogerus [this message]
2015-03-18 12:40 ` [PATCHv2 07/12] usb: dwc3: setup phys earlier Heikki Krogerus
2015-03-18 12:40 ` [PATCHv2 08/12] usb: dwc3: add hsphy_interface property Heikki Krogerus
2015-03-18 12:40 ` [PATCHv2 09/12] usb: dwc3: pci: add quirk for Baytrails Heikki Krogerus
2015-03-18 17:08   ` David Cohen
2015-03-19 11:51     ` Heikki Krogerus
2015-03-20 12:20       ` [PATCHv3 " Heikki Krogerus
2015-03-18 12:40 ` [PATCHv2 10/12] usb: dwc3: add ULPI interface support Heikki Krogerus
2015-03-18 22:53   ` Paul Bolle
2015-03-19 11:48     ` Heikki Krogerus
2015-03-20 12:20       ` [PATCHv3 " Heikki Krogerus
2015-03-18 12:40 ` [PATCHv2 11/12] phy: helpers for USB ULPI PHY registering Heikki Krogerus
2015-03-18 14:46   ` Sergei Shtylyov
2015-03-18 16:54     ` David Cohen
2015-03-18 18:02       ` Sergei Shtylyov
2015-03-18 12:40 ` [PATCHv2 12/12] phy: add driver for TI TUSB1210 ULPI PHY Heikki Krogerus
2015-03-18 17:12 ` [PATCHv2 00/12] usb: ulpi bus David Cohen
2015-03-18 17:19   ` David Cohen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1426682433-133813-7-git-send-email-heikki.krogerus@linux.intel.com \
    --to=heikki.krogerus@linux.intel.com \
    --cc=balbi@ti.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=david.a.cohen@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).