From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933333AbbCRNcf (ORCPT <rfc822;w@1wt.eu>);
	Wed, 18 Mar 2015 09:32:35 -0400
Received: from mailout3.w1.samsung.com ([210.118.77.13]:47295 "EHLO
	mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S933219AbbCRNc3 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 18 Mar 2015 09:32:29 -0400
MIME-version: 1.0
Content-type: text/plain; charset=UTF-8
X-AuditID: cbfec7f4-b7f126d000001e9a-e0-55097dd9c1cd
Content-transfer-encoding: 8BIT
Message-id: <1426685545.23982.2.camel@AMDC1943>
Subject: Re: [PATCH v3 1/4] ARM: EXYNOS: fix CPU1 hotplug for AFTR mode on
 Exynos3250
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Kukjin Kim <kgene.kim@samsung.com>, Kukjin Kim <kgene@kernel.org>,
        linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Tomasz Figa <tomasz.figa@gmail.com>, linux-kernel@vger.kernel.org,
        Chanwoo Choi <cw00.choi@samsung.com>,
        Kyungmin Park <kyungmin.park@samsung.com>,
        linux-arm-kernel@lists.infradead.org
Date: Wed, 18 Mar 2015 14:32:25 +0100
In-reply-to: <3449559.PngGo6WKuq@amdc1032>
References: <1426683113-31209-1-git-send-email-b.zolnierkie@samsung.com>
 <1426683113-31209-2-git-send-email-b.zolnierkie@samsung.com>
 <CAJKOXPe3P0mO-WuufAwF_tB6P=kfr-ORyQ6pa2pRnvjytCuHZg@mail.gmail.com>
 <3449559.PngGo6WKuq@amdc1032>
X-Mailer: Evolution 3.10.4-0ubuntu2
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrOLMWRmVeSWpSXmKPExsVy+t/xa7o3azlDDZo+mlhsnLGe1eL6l+es
	FvM+y1q8fmFo0bvgKptF/+PXzBZnm96wW2x6fI3V4vKuOWwWn3uPMFrMOL+PyWLVrj+MDjwe
	O2fdZffYtKqTzePOtT1sHpuX1Hv0bVnF6PF5k1wAWxSXTUpqTmZZapG+XQJXxoxlG1kKrnJU
	/Hn7kbmB8RFbFyMnh4SAicSUa99YIWwxiQv31oPFhQSWMkrMfJQFYvMKCEr8mHyPpYuRg4NZ
	QF7iyKVskDCzgLrEpHmLmLsYuYDKPzNKLDv8kxmiXl+i4dlMsJnCAuESsw+/AbPZBIwlNi9f
	AjZfRMBCYu2KtywgzcwCn5gkem5PZwJJsAioShx5tBisgVNAS6Lx6QR2iA3vGCV2rPjJBHKF
	hICyRGO/2wRGgVlI7puFcN8sJPctYGRexSiaWppcUJyUnmuoV5yYW1yal66XnJ+7iRESGV92
	MC4+ZnWIUYCDUYmH1+EHR6gQa2JZcWXuIUYJDmYlEV7uLM5QId6UxMqq1KL8+KLSnNTiQ4xM
	HJxSDYymdzQuXI1wDN965lHsx/Uscx9r79DIF9bqznX6wsT7avueFwzOB9Jyln57Eicz/YPv
	ojo5pk/BFR2+OnebV87z1Lzgefn32f0XIl6XCF1ZE7X5L0/lArnG1n/NPY9ma9d5xEXahWZc
	zzf4KKio9lFnR6VWtcZlU/7Likv7tB/efxLYciov67kSS3FGoqEWc1FxIgAlFM1OagIAAA==
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On śro, 2015-03-18 at 14:23 +0100, Bartlomiej Zolnierkiewicz wrote:
> Hi,
> 
> On Wednesday, March 18, 2015 02:10:31 PM Krzysztof Kozlowski wrote:
> > 2015-03-18 13:51 GMT+01:00 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>:
> > >
> > > +       while (!pmu_raw_readl(S5P_PMU_SPARE2))
> > > +               udelay(10);
> > > +       udelay(10);
> > 
> > We really need to start documenting this. Please add short description
> > why this SPARE2 check is here and who uses it. Without documenting
> > this behavior future generations won't be able to debug this stuff.
> > Imagine replacing sboot with uboot by someone...
> 
> I've already planned to do this for this code and for coupled cpuidle
> use of SPARE2 as well.  However I would really prefer to do it in
> an incremental patch if there are no other issues with this patchset.

OK, please do so in incremental patch. Usage of various memory regions
of sysram also should be documented. In patch 2 you add usage of 0x28 +
4*cpu. The various sysrams regions are spread over different files...

Best regards,
Krzysztof