From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755663AbbCRQWz (ORCPT ); Wed, 18 Mar 2015 12:22:55 -0400 Received: from cpsmtpb-ews04.kpnxchange.com ([213.75.39.7]:60494 "EHLO cpsmtpb-ews04.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750729AbbCRQWy (ORCPT ); Wed, 18 Mar 2015 12:22:54 -0400 Message-ID: <1426695772.23586.5.camel@x220> Subject: Re: [PATCH v2] drm/i915: gen4: work around hang during hibernation From: Paul Bolle To: Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= Cc: Imre Deak , intel-gfx@lists.freedesktop.org, =?ISO-8859-1?Q?Bj=F8rn?= Mork , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter , Jani Nikula , David Weinehall Date: Wed, 18 Mar 2015 17:22:52 +0100 In-Reply-To: <20150318102201.GM17419@intel.com> References: <1425294281-7297-1-git-send-email-imre.deak@intel.com> <1426671436.2649.19.camel@tiscali.nl> <20150318102201.GM17419@intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-OriginalArrivalTime: 18 Mar 2015 16:22:52.0596 (UTC) FILETIME=[C8868740:01D06197] X-RcptDomain: vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-03-18 at 12:22 +0200, Ville Syrjälä wrote: > We had another bug report which showed similar problems on something > as recent as SNB: > https://bugzilla.kernel.org/show_bug.cgi?id=94241 > So I guess we really want to make the check 'gen < 7'. > > My IVB X1 Carbon doesn't need this quirk, so hopefully that indicates > the Lenovo BIOSen became more sane for gen7+. On the other hand my ThinkPad X220 has vendor:device ids 8086:0126, which makes it a gen6 device (assuming I parsed the various preprocessor defines in include/drm/i915_pciids.h and drivers/gpu/drm/i915/i915_drv.c correctly). That laptop is now running v3.19.1 and never hit this issue. Paul Bolle