From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Borislav Petkov <bp@alien8.de>,
Doug Thompson <dougthompson@xmission.com>,
Tejun Heo <tj@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
Olof Johansson <olof@lixom.net>,
Arjan van de Ven <arjan@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Luis R . Rodriguez" <mcgrof@suse.com>
Subject: [PATCH 2/3] EDAC: amd64_edac: clean up remove_one_instance()
Date: Wed, 18 Mar 2015 17:49:09 -0700 [thread overview]
Message-ID: <1426726150-983-3-git-send-email-dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <1426726150-983-1-git-send-email-dmitry.torokhov@gmail.com>
We can get much of data from driver-proivate structure so make use of
it.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/edac/amd64_edac.c | 17 ++++++-----------
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
index c0ebc06..d23dad9 100644
--- a/drivers/edac/amd64_edac.c
+++ b/drivers/edac/amd64_edac.c
@@ -2774,7 +2774,7 @@ static int init_one_instance(struct pci_dev *F2)
if (!pvt)
goto err_ret;
- pvt->mc_node_id = nid;
+ pvt->mc_node_id = nid;
pvt->F2 = F2;
ret = -EINVAL;
@@ -2849,6 +2849,8 @@ static int init_one_instance(struct pci_dev *F2)
amd_register_ecc_decoder(decode_bus_error);
+ pci_set_drvdata(F2, pvt);
+
atomic_inc(&drv_instances);
return 0;
@@ -2890,22 +2892,15 @@ static int probe_one_instance(struct pci_dev *pdev,
static void remove_one_instance(struct pci_dev *pdev)
{
+ struct amd64_pvt *pvt = pci_get_drvdata(pdev);
struct mem_ctl_info *mci;
- struct amd64_pvt *pvt;
- u16 nid = amd_get_node_id(pdev);
- struct pci_dev *F3 = node_to_amd_nb(nid)->misc;
-
- mci = find_mci_by_dev(&pdev->dev);
- WARN_ON(!mci);
/* Remove from EDAC CORE tracking list */
mci = edac_mc_del_mc(&pdev->dev);
- if (!mci)
+ if (WARN_ON(!mci))
return;
- pvt = mci->pvt_info;
-
- restore_ecc_error_reporting(&pvt->ecc, nid, F3);
+ restore_ecc_error_reporting(&pvt->ecc, pvt->mc_node_id, pvt->F3);
free_mc_sibling_devs(pvt);
--
2.2.0.rc0.207.ga3a616c
next prev parent reply other threads:[~2015-03-19 0:49 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 0:49 [RFC/RFT] amd64_edac: avoid doing post-probe setup Dmitry Torokhov
2015-03-19 0:49 ` [PATCH 1/3] EDAC: amd64: stop allocating ecc settings separately Dmitry Torokhov
2015-03-19 0:49 ` Dmitry Torokhov [this message]
2015-03-19 0:49 ` [PATCH 3/3] EDAC: amd64_edac: decide if driver can load successfully early Dmitry Torokhov
2015-03-19 9:40 ` Borislav Petkov
2015-03-19 15:29 ` Tejun Heo
2015-03-19 15:35 ` Borislav Petkov
2015-03-19 15:52 ` Dmitry Torokhov
2015-03-19 15:59 ` Borislav Petkov
2015-03-19 16:12 ` Dmitry Torokhov
2015-03-19 16:23 ` Borislav Petkov
2015-03-19 16:33 ` Tejun Heo
2015-03-19 16:45 ` Borislav Petkov
2015-03-19 16:49 ` Tejun Heo
2015-03-19 16:56 ` Borislav Petkov
2015-03-19 17:03 ` Tejun Heo
2015-03-19 17:04 ` Borislav Petkov
2015-03-19 17:10 ` Tejun Heo
2015-03-19 17:15 ` Tejun Heo
2015-03-19 17:27 ` Borislav Petkov
2015-03-19 17:47 ` Tejun Heo
2015-03-19 17:54 ` Borislav Petkov
2015-03-19 18:05 ` Tejun Heo
2015-03-19 16:52 ` Dmitry Torokhov
2015-03-19 17:09 ` Tejun Heo
2015-03-19 15:55 ` Tejun Heo
2015-03-19 16:01 ` Borislav Petkov
2015-03-19 16:12 ` Tejun Heo
2015-03-19 16:57 ` Dmitry Torokhov
2015-03-19 17:22 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426726150-983-3-git-send-email-dmitry.torokhov@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=arjan@linux.intel.com \
--cc=bp@alien8.de \
--cc=dougthompson@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@suse.com \
--cc=mchehab@osg.samsung.com \
--cc=olof@lixom.net \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).