From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751386AbbCSJNU (ORCPT ); Thu, 19 Mar 2015 05:13:20 -0400 Received: from smtprelay0127.hostedemail.com ([216.40.44.127]:52176 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750915AbbCSJNR (ORCPT ); Thu, 19 Mar 2015 05:13:17 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1593:1594:1711:1714:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3350:3622:3865:3867:3868:3871:3872:3874:4321:5007:6119:6261:10004:10400:10848:11026:11232:11658:11914:12296:12517:12519:12740:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: neck33_3897025370742 X-Filterd-Recvd-Size: 1477 Message-ID: <1426756387.21142.1.camel@perches.com> Subject: Re: [PATCH v2] checkpatch: support more uppercase $logFunctions From: Joe Perches To: Tom Van Braeckel Cc: apw@canonical.com, linux-kernel@vger.kernel.org Date: Thu, 19 Mar 2015 02:13:07 -0700 In-Reply-To: <1426753601-4109-1-git-send-email-tomvanbraeckel@gmail.com> References: <1426746080-11905-1-git-send-email-tomvanbraeckel@gmail.com> <1426753601-4109-1-git-send-email-tomvanbraeckel@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-03-19 at 09:26 +0100, Tom Van Braeckel wrote: > Add support for uppercase logging function names (so that they may > exceed 80 cols) and regroup the matched expressions more logically. > > Previously, WARN, WARN_RATELIMIT, WARN_ONCE were already supported but > many other uppercase logging functions were not and this caused > unfixable checkpatch warnings (an example: drivers/bluetooth/btusb.c) I think BT_DBG is a poor macro as it's just #define BT_DBG(fmt, ...) pr_debug(fmt "\n", ##__VA_ARGS__) and I'd rather see a treewide sed for that to pr_debug