From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
lm-sensors <lm-sensors@lm-sensors.org>,
Andrew Morton <akpm@linux-foundation.org>,
Steven Rostedt <srostedt@redhat.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: [PATCH v3 2/4] hwmon: (ina2xx) replace ina226_avg_bits() with find_closest()
Date: Thu, 19 Mar 2015 15:30:18 +0100 [thread overview]
Message-ID: <1426775420-31350-3-git-send-email-bgolaszewski@baylibre.com> (raw)
In-Reply-To: <1426775420-31350-1-git-send-email-bgolaszewski@baylibre.com>
Use find_closest() to locate the closest average in ina226_avg_tab.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
drivers/hwmon/ina2xx.c | 17 +++--------------
1 file changed, 3 insertions(+), 14 deletions(-)
diff --git a/drivers/hwmon/ina2xx.c b/drivers/hwmon/ina2xx.c
index d1542b7..4d28150 100644
--- a/drivers/hwmon/ina2xx.c
+++ b/drivers/hwmon/ina2xx.c
@@ -36,6 +36,7 @@
#include <linux/jiffies.h>
#include <linux/of.h>
#include <linux/delay.h>
+#include <linux/util_macros.h>
#include <linux/platform_data/ina2xx.h>
@@ -141,19 +142,6 @@ static const struct ina2xx_config ina2xx_config[] = {
*/
static const int ina226_avg_tab[] = { 1, 4, 16, 64, 128, 256, 512, 1024 };
-static int ina226_avg_bits(int avg)
-{
- int i;
-
- /* Get the closest average from the tab. */
- for (i = 0; i < ARRAY_SIZE(ina226_avg_tab) - 1; i++) {
- if (avg <= (ina226_avg_tab[i] + ina226_avg_tab[i + 1]) / 2)
- break;
- }
-
- return i; /* Return 0b0111 for values greater than 1024. */
-}
-
static int ina226_reg_to_interval(u16 config)
{
int avg = ina226_avg_tab[INA226_READ_AVG(config)];
@@ -171,7 +159,8 @@ static u16 ina226_interval_to_reg(int interval, u16 config)
avg = DIV_ROUND_CLOSEST(interval * 1000,
INA226_TOTAL_CONV_TIME_DEFAULT);
- avg_bits = ina226_avg_bits(avg);
+ avg_bits = find_closest(avg, ina226_avg_tab,
+ ARRAY_SIZE(ina226_avg_tab));
return (config & ~INA226_AVG_RD_MASK) | INA226_SHIFT_AVG(avg_bits);
}
--
2.1.4
next prev parent reply other threads:[~2015-03-19 14:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 14:30 [PATCH v3 0/4] new macro: find_closest() Bartosz Golaszewski
2015-03-19 14:30 ` [PATCH v3 1/4] util_macros.h: add find_closest() macro Bartosz Golaszewski
2015-03-19 15:15 ` Joe Perches
2015-03-19 16:21 ` Bartosz Golaszewski
2015-03-19 16:03 ` Steven Rostedt
2015-03-19 16:28 ` Bartosz Golaszewski
2015-03-19 16:32 ` Steven Rostedt
2015-03-19 16:33 ` Steven Rostedt
2015-03-19 16:48 ` Bartosz Golaszewski
2015-03-19 16:36 ` Bartosz Golaszewski
2015-03-19 14:30 ` Bartosz Golaszewski [this message]
2015-03-19 14:30 ` [PATCH v3 3/4] hwmon: (lm85) use find_closest() in x_TO_REG() functions Bartosz Golaszewski
2015-03-19 14:30 ` [PATCH v3 4/4] hwmon: (w83795) use find_closest_descending() in pwm_freq_to_reg() Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426775420-31350-3-git-send-email-bgolaszewski@baylibre.com \
--to=bgolaszewski@baylibre.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
--cc=srostedt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox