From: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
To: Hans Verkuil <hans.verkuil@cisco.com>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Arun Kumar K <arun.kk@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Antti Palosaari <crope@iki.fi>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Subject: [PATCH 1/5] media/v4l2-ctrls: volatiles should not generate CH_VALUE
Date: Thu, 19 Mar 2015 16:21:22 +0100 [thread overview]
Message-ID: <1426778486-21807-2-git-send-email-ricardo.ribalda@gmail.com> (raw)
In-Reply-To: <1426778486-21807-1-git-send-email-ricardo.ribalda@gmail.com>
Volatile controls should not generate CH_VALUE events.
Set has_changed to false to prevent this happening.
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
drivers/media/v4l2-core/v4l2-ctrls.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c
index 45c5b47..627d4c7 100644
--- a/drivers/media/v4l2-core/v4l2-ctrls.c
+++ b/drivers/media/v4l2-core/v4l2-ctrls.c
@@ -1609,6 +1609,15 @@ static int cluster_changed(struct v4l2_ctrl *master)
if (ctrl == NULL)
continue;
+ /*
+ * Set has_changed to false to avoid generating
+ * the event V4L2_EVENT_CTRL_CH_VALUE
+ */
+ if (ctrl->flags & V4L2_CTRL_FLAG_VOLATILE){
+ ctrl->has_changed = false;
+ continue;
+ }
+
for (idx = 0; !ctrl_changed && idx < ctrl->elems; idx++)
ctrl_changed = !ctrl->type_ops->equal(ctrl, idx,
ctrl->p_cur, ctrl->p_new);
--
2.1.4
next prev parent reply other threads:[~2015-03-19 15:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 15:21 [PATCH 0/5] V4L2_CTRL_FLAG_EXECUTE_ON_WRITE Ricardo Ribalda Delgado
2015-03-19 15:21 ` Ricardo Ribalda Delgado [this message]
2015-03-20 12:38 ` [PATCH 1/5] media/v4l2-ctrls: volatiles should not generate CH_VALUE Sakari Ailus
2015-03-19 15:21 ` [PATCH 2/5] media: New flag V4L2_CTRL_FLAG_EXECUTE_ON_WRITE Ricardo Ribalda Delgado
2015-03-20 13:34 ` Hans Verkuil
2015-03-19 15:21 ` [PATCH 3/5] media/v4l2-ctrls: Add execute flags to write_only controls Ricardo Ribalda Delgado
2015-03-20 14:16 ` Laurent Pinchart
2015-03-19 15:21 ` [PATCH 4/5] media/v4l2-ctrls: Always execute EXECUTE_ON_WRITE ctrls Ricardo Ribalda Delgado
2015-03-20 13:46 ` Hans Verkuil
2015-03-19 15:21 ` [PATCH 5/5] media/Documentation: New flag EXECUTE_ON_WRITE Ricardo Ribalda Delgado
2015-03-20 13:56 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426778486-21807-2-git-send-email-ricardo.ribalda@gmail.com \
--to=ricardo.ribalda@gmail.com \
--cc=arun.kk@samsung.com \
--cc=crope@iki.fi \
--cc=hans.verkuil@cisco.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=s.nawrocki@samsung.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox