From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751565AbbCSTc5 (ORCPT ); Thu, 19 Mar 2015 15:32:57 -0400 Received: from cpsmtpb-ews06.kpnxchange.com ([213.75.39.9]:55782 "EHLO cpsmtpb-ews06.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750853AbbCSTcy (ORCPT ); Thu, 19 Mar 2015 15:32:54 -0400 Message-ID: <1426793571.23529.14.camel@x220> Subject: Re: [PATCH] vfio: Split virqfd into a separate module for vfio bus drivers From: Paul Bolle To: Alex Williamson Cc: kvm@vger.kernel.org, b.reynal@virtualopensystems.com, linux-kernel@vger.kernel.org, eric.auger@linaro.org Date: Thu, 19 Mar 2015 20:32:51 +0100 In-Reply-To: <20150318172352.18444.97999.stgit@gimli.home> References: <20150318172352.18444.97999.stgit@gimli.home> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 19 Mar 2015 19:32:51.0486 (UTC) FILETIME=[7D34DBE0:01D0627B] X-RcptDomain: vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-03-18 at 11:27 -0600, Alex Williamson wrote: > --- a/drivers/vfio/virqfd.c > +++ b/drivers/vfio/virqfd.c > +#define DRIVER_VERSION "0.1" > +#define DRIVER_AUTHOR "Alex Williamson " > +#define DRIVER_DESC "IRQFD support for VFIO bus drivers" > +MODULE_VERSION(DRIVER_VERSION); > +MODULE_LICENSE("GPL v2"); > +MODULE_AUTHOR(DRIVER_AUTHOR); > +MODULE_DESCRIPTION(DRIVER_DESC); Why bother with those three defines? They're all used just once, aren't they? Paul Bolle