From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751226AbbCSUO1 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 19 Mar 2015 16:14:27 -0400
Received: from g4t3426.houston.hp.com ([15.201.208.54]:55895 "EHLO
	g4t3426.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750778AbbCSUO0 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 19 Mar 2015 16:14:26 -0400
Message-ID: <1426796054.2370.64.camel@j-VirtualBox>
Subject: Re: [PATCH v2] sched, timer: Use atomics for thread_group_cputimer
 to improve scalability
From: Jason Low <jason.low2@hp.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Oleg Nesterov <oleg@redhat.com>,
        Mike Galbraith <umgwanakikbuti@gmail.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Rik van Riel <riel@redhat.com>, Steven Rostedt <rostedt@goodmis.org>,
        Scott Norton <scott.norton@hp.com>,
        Aswin Chandramouleeswaran <aswin@hp.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        jason.low2@hp.com
Date: Thu, 19 Mar 2015 13:14:14 -0700
In-Reply-To: <CA+55aFwyC5YDKgmc_FFi7QEDO_5io+2y-xneMtyuHApsURGaxg@mail.gmail.com>
References: <1425321731.5304.14.camel@j-VirtualBox>
	 <CA+55aFzHots3xj94bpv8Lef8o1Z0rZdRd=fE5_cMrqXhZjEOpw@mail.gmail.com>
	 <1425332984.5304.66.camel@j-VirtualBox>
	 <1426785661.2370.38.camel@j-VirtualBox>
	 <CA+55aFwyC5YDKgmc_FFi7QEDO_5io+2y-xneMtyuHApsURGaxg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.2.3-0ubuntu6 
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 2015-03-19 at 10:59 -0700, Linus Torvalds wrote:
> On Thu, Mar 19, 2015 at 10:21 AM, Jason Low <jason.low2@hp.com> wrote:
> >
> > I tested this patch on a 32 bit ARM system with 4 cores. Using the
> > generic 64 bit atomics, I did not see any performance change with this
> > patch, and the relevant functions (account_group_*_time(), ect...) don't
> > show up in perf reports.
> 
> Ok.
> 
> > One factor might be because locking/cacheline contention isn't as
> > apparent on smaller systems to begin with, and lib/atomic64.c also
> > mentions that "this is expected to used on systems with small numbers of
> > CPUs (<= 4 or so)".
> 
> Yeah, that's probably a valid argument anyway - 32-bit systems aren't
> really going to be multi-node big systems any more.
> 
> So I'm ok with the patch,

Okay, I will be sending out a v3 patch which will also mention a bit
about its effect on 32 bit systems in the changelog, in addition to the
changes that were discussed about in this thread (using WRITE_ONCE(),
ect...).

Thanks,
Jason