From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751820AbbCUL70 (ORCPT ); Sat, 21 Mar 2015 07:59:26 -0400 Received: from cpsmtpb-ews09.kpnxchange.com ([213.75.39.14]:61059 "EHLO cpsmtpb-ews09.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751349AbbCUL7V (ORCPT ); Sat, 21 Mar 2015 07:59:21 -0400 Message-ID: <1426939159.15426.4.camel@x220> Subject: Re: [PATCH v1 04/11] stm class: stm_console: Add kernel-console-over-stm driver From: Paul Bolle To: Alexander Shishkin Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, mathieu.poirier@linaro.org, peter.lachner@intel.com, norbert.schulz@intel.com, keven.boell@intel.com, yann.fouassier@intel.com, laurent.fert@intel.com, Pratik Patel Date: Sat, 21 Mar 2015 12:59:19 +0100 In-Reply-To: <1426872598-68807-5-git-send-email-alexander.shishkin@linux.intel.com> References: <1426872598-68807-1-git-send-email-alexander.shishkin@linux.intel.com> <1426872598-68807-5-git-send-email-alexander.shishkin@linux.intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 21 Mar 2015 11:59:19.0350 (UTC) FILETIME=[7655ED60:01D063CE] X-RcptDomain: vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org All I spotted is two nits. On Fri, 2015-03-20 at 19:29 +0200, Alexander Shishkin wrote: > +config STM_SOURCE_CONSOLE > + tristate "Kernel console over STM devices" Tab instead of eight spaces, please. > + default N You meant default n as n is a magic symbol. But n is the default anyway, so I think you might as well drop this line. > + help > + This is a kernel space trace source that sends kernel log > + messages to trace hosts over STM devices. > + > + If you want to send kernel console messages over STM devices, > + say Y. Paul Bolle