From: Paul Bolle <pebolle@tiscali.nl>
To: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, mathieu.poirier@linaro.org,
peter.lachner@intel.com, norbert.schulz@intel.com,
keven.boell@intel.com, yann.fouassier@intel.com,
laurent.fert@intel.com, Pratik Patel <pratikp@codeaurora.org>
Subject: Re: [PATCH v1 03/11] stm class: dummy_stm: Add dummy driver for testing stm class
Date: Sat, 21 Mar 2015 13:02:31 +0100 [thread overview]
Message-ID: <1426939351.15426.7.camel@x220> (raw)
In-Reply-To: <1426872598-68807-4-git-send-email-alexander.shishkin@linux.intel.com>
All I spotted is the same two nits as in 04/11.
On Fri, 2015-03-20 at 19:29 +0200, Alexander Shishkin wrote:
> --- a/drivers/hwtracing/stm/Kconfig
> +++ b/drivers/hwtracing/stm/Kconfig
> +config STM_DUMMY
> + tristate "Dummy STM driver"
Tab instead of eight spaces, please.
> + default N
You meant
default n
as n is a magic symbol. But n is the default anyway, so I think you
might as well drop this line.
> + help
> + This is a simple dummy device that pretends to be an stm device
> + and discards your data. Use for stm class testing.
> +
> + If you don't know what this is, say N.
Paul Bolle
next prev parent reply other threads:[~2015-03-21 12:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 17:29 [PATCH v1 00/11] Introduce Intel Trace Hub support Alexander Shishkin
2015-03-20 17:29 ` [PATCH v1 01/11] stm class: Introduce an abstraction for System Trace Module devices Alexander Shishkin
2015-03-20 17:29 ` [PATCH v1 02/11] MAINTAINERS: add an entry for System Trace Module device class Alexander Shishkin
2015-03-20 17:29 ` [PATCH v1 03/11] stm class: dummy_stm: Add dummy driver for testing stm class Alexander Shishkin
2015-03-21 12:02 ` Paul Bolle [this message]
2015-03-22 20:38 ` Alexander Shishkin
2015-03-20 17:29 ` [PATCH v1 04/11] stm class: stm_console: Add kernel-console-over-stm driver Alexander Shishkin
2015-03-21 11:59 ` Paul Bolle
2015-03-20 17:29 ` [PATCH v1 05/11] intel_th: Add driver infrastructure for Intel Trace Hub devices Alexander Shishkin
2015-03-20 17:29 ` [PATCH v1 06/11] intel_th: Add pci glue layer for Intel Trace Hub Alexander Shishkin
2015-03-20 17:43 ` Joe Perches
2015-03-22 20:36 ` Alexander Shishkin
2015-03-20 17:29 ` [PATCH v1 07/11] intel_th: Add Global Trace Hub driver Alexander Shishkin
2015-03-20 17:59 ` Joe Perches
2015-03-22 20:35 ` Alexander Shishkin
2015-03-20 17:29 ` [PATCH v1 08/11] intel_th: Add Software " Alexander Shishkin
2015-03-20 17:29 ` [PATCH v1 09/11] intel_th: Add Memory Storage Unit driver Alexander Shishkin
2015-03-20 17:29 ` [PATCH v1 10/11] intel_th: Add PTI output driver Alexander Shishkin
2015-03-20 17:29 ` [PATCH v1 11/11] MAINTAINERS: add an entry for Intel(R) Trace Hub Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426939351.15426.7.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=alexander.shishkin@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=keven.boell@intel.com \
--cc=laurent.fert@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=norbert.schulz@intel.com \
--cc=peter.lachner@intel.com \
--cc=pratikp@codeaurora.org \
--cc=yann.fouassier@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox