From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751781AbbCURA3 (ORCPT ); Sat, 21 Mar 2015 13:00:29 -0400 Received: from mail-yh0-f68.google.com ([209.85.213.68]:36806 "EHLO mail-yh0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751403AbbCURA2 (ORCPT ); Sat, 21 Mar 2015 13:00:28 -0400 From: Sanidhya Kashyap To: jack@suse.cz, jeffm@suse.com, akpm@linux-foundation.org, fabf@skynet.be, josh@joshtriplett.org, rashika.kheria@gmail.com, reiserfs-devel@vger.kernel.org, linux-kernel@vger.kernel.org Cc: taesoo@gatech.edu, changwoo@gatech.edu, sanidhya@gatech.edu, blee@gatech.edu, Sanidhya Kashyap Subject: [PATCH] reiserfs: kstrdup() memory handling Date: Sat, 21 Mar 2015 13:00:13 -0400 Message-Id: <1426957213-5508-1-git-send-email-sanidhya.gatech@gmail.com> X-Mailer: git-send-email 2.1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Checking for ENOMEM even for new_opts in reiserfs_remount function as there is a possibility of nothing being allocated. Signed-off-by: Sanidhya Kashyap --- fs/reiserfs/super.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/fs/reiserfs/super.c b/fs/reiserfs/super.c index 71fbbe3..bf9bc66 100644 --- a/fs/reiserfs/super.c +++ b/fs/reiserfs/super.c @@ -1397,6 +1397,11 @@ static int reiserfs_remount(struct super_block *s, int *mount_flags, char *arg) int i; #endif + if (!new_opts) { + err = -ENOMEM; + goto out_err_no_kfree; + } + sync_filesystem(s); reiserfs_write_lock(s); @@ -1549,6 +1554,7 @@ out_err_unlock: reiserfs_write_unlock(s); out_err: kfree(new_opts); +out_err_no_kfree: return err; } -- 2.1.0