public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xfs: Fix incorrect positive ENOMEM return
@ 2015-03-22 19:03 Joe Perches
  0 siblings, 0 replies; only message in thread
From: Joe Perches @ 2015-03-22 19:03 UTC (permalink / raw)
  To: Dave Chinner; +Cc: xfs, LKML

commit 5681ca40064f ("xfs: Remove icsb infrastructure")
incorrectly added a positive error return value.

This value filters up through the return layers
and should be negative as the other return values
are in the same function.

Signed-off-by: Joe Perches <joe@perches.com>
---
 fs/xfs/xfs_super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
index 3ad0b17..8782b36 100644
--- a/fs/xfs/xfs_super.c
+++ b/fs/xfs/xfs_super.c
@@ -1380,7 +1380,7 @@ xfs_init_percpu_counters(
 
 	error = percpu_counter_init(&mp->m_icount, 0, GFP_KERNEL);
 	if (error)
-		return ENOMEM;
+		return -ENOMEM;
 
 	error = percpu_counter_init(&mp->m_ifree, 0, GFP_KERNEL);
 	if (error)



^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2015-03-22 19:03 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-22 19:03 [PATCH] xfs: Fix incorrect positive ENOMEM return Joe Perches

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox