From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751966AbbCVTDc (ORCPT ); Sun, 22 Mar 2015 15:03:32 -0400 Received: from smtprelay0123.hostedemail.com ([216.40.44.123]:58037 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751827AbbCVTDa (ORCPT ); Sun, 22 Mar 2015 15:03:30 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::,RULES_HIT:41:355:379:541:800:960:966:968:973:988:989:1260:1277:1311:1313:1314:1345:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2196:2198:2199:2200:2393:2559:2562:2828:3138:3139:3140:3141:3142:3350:3865:3868:3870:4321:4385:5007:6261:10004:10400:10848:11026:11658:11914:12043:12438:12517:12519:12555:13069:13311:13357:14096:14097:14394:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: copy45_14c6fc24890e X-Filterd-Recvd-Size: 1418 Message-ID: <1427051007.27543.21.camel@perches.com> Subject: [PATCH] xfs: Fix incorrect positive ENOMEM return From: Joe Perches To: Dave Chinner Cc: xfs , LKML Date: Sun, 22 Mar 2015 12:03:27 -0700 Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org commit 5681ca40064f ("xfs: Remove icsb infrastructure") incorrectly added a positive error return value. This value filters up through the return layers and should be negative as the other return values are in the same function. Signed-off-by: Joe Perches --- fs/xfs/xfs_super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c index 3ad0b17..8782b36 100644 --- a/fs/xfs/xfs_super.c +++ b/fs/xfs/xfs_super.c @@ -1380,7 +1380,7 @@ xfs_init_percpu_counters( error = percpu_counter_init(&mp->m_icount, 0, GFP_KERNEL); if (error) - return ENOMEM; + return -ENOMEM; error = percpu_counter_init(&mp->m_ifree, 0, GFP_KERNEL); if (error)