From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752491AbbCWLu0 (ORCPT ); Mon, 23 Mar 2015 07:50:26 -0400 Received: from foss.arm.com ([217.140.101.70]:45286 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752035AbbCWLuY (ORCPT ); Mon, 23 Mar 2015 07:50:24 -0400 Message-ID: <1427111422.3726.23.camel@arm.com> Subject: Re: [PATCH] virtio_mmio: generation support From: Pawel Moll To: Rusty Russell Cc: "Michael S. Tsirkin" , "linux-kernel@vger.kernel.org" , "virtualization@lists.linux-foundation.org" Date: Mon, 23 Mar 2015 11:50:22 +0000 In-Reply-To: <87y4n3vuh6.fsf@rustcorp.com.au> References: <1425593244-18869-1-git-send-email-mst@redhat.com> <87y4n3vuh6.fsf@rustcorp.com.au> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-03-12 at 02:07 +0000, Rusty Russell wrote: > "Michael S. Tsirkin" writes: > > virtio_mmio currently lacks generation support which > > makes multi-byte field access racy. > > Fix by getting the value at offset 0xfc for version 2 > > devices. Nothing we can do for version 1, so return > > generation id 0. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > > > Pawel, you mentioned you have a working virtio 1.0 > > hypervisor, can you pls confirm this works correctly? Again, belated Acked-by: Pawel Moll although not yet tested-by... Paweł