From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752651AbbCWOUe (ORCPT ); Mon, 23 Mar 2015 10:20:34 -0400 Received: from foss.arm.com ([217.140.101.70]:45747 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752553AbbCWOUc (ORCPT ); Mon, 23 Mar 2015 10:20:32 -0400 Message-ID: <1427120430.3726.28.camel@arm.com> Subject: Re: [PATCH 19/35 linux-next] virtio_mmio: constify of_device_id array From: Pawel Moll To: Fabian Frederick Cc: "linux-kernel@vger.kernel.org" , Greg Kroah-Hartman , "virtualization@lists.linux-foundation.org" , "Michael S. Tsirkin" Date: Mon, 23 Mar 2015 14:20:30 +0000 In-Reply-To: <1426533651-25586-10-git-send-email-fabf@skynet.be> References: <1426533469-25458-1-git-send-email-fabf@skynet.be> <1426533651-25586-1-git-send-email-fabf@skynet.be> <1426533651-25586-10-git-send-email-fabf@skynet.be> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-03-16 at 19:20 +0000, Fabian Frederick wrote: > of_device_id is always used as const. > (See driver.of_match_table and open firmware functions) > > Signed-off-by: Fabian Frederick > --- > drivers/virtio/virtio_mmio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c > index 9c877d2..0ce8cda 100644 > --- a/drivers/virtio/virtio_mmio.c > +++ b/drivers/virtio/virtio_mmio.c > @@ -671,7 +671,7 @@ static void vm_unregister_cmdline_devices(void) > > /* Platform driver */ > > -static struct of_device_id virtio_mmio_match[] = { > +static const struct of_device_id virtio_mmio_match[] = { > { .compatible = "virtio,mmio", }, > {}, > }; Acked-by: Pawel Moll Thanks! Pawel