From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753197AbbCWPhL (ORCPT ); Mon, 23 Mar 2015 11:37:11 -0400 Received: from smtprelay0151.hostedemail.com ([216.40.44.151]:54185 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753163AbbCWPhE (ORCPT ); Mon, 23 Mar 2015 11:37:04 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3350:3622:3865:3866:3870:3871:3873:3874:4321:5007:6261:10004:10400:10848:11232:11658:11914:12296:12517:12519:12663:12740:13019:13069:13071:13311:13357:21060:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: bag79_31ef14db6f2a X-Filterd-Recvd-Size: 1638 Message-ID: <1427125019.16851.20.camel@perches.com> Subject: Re: [PATCH -next] netfilter: Use LOGLEVEL_ defines From: Joe Perches To: Stephen Rothwell Cc: Pablo Neira Ayuso , David Miller , netdev@vger.kernel.org, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Patrick McHardy Date: Mon, 23 Mar 2015 08:36:59 -0700 In-Reply-To: <20150324003828.0eac53d9@canb.auug.org.au> References: <20150323140841.0b807b95@canb.auug.org.au> <20150323124723.GA6740@salvia> <1427115331.16851.11.camel@perches.com> <20150323130638.GA6857@salvia> <1427117031.16851.16.camel@perches.com> <20150324003828.0eac53d9@canb.auug.org.au> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-03-24 at 00:38 +1100, Stephen Rothwell wrote: > Hi Joe, Hi Stephen. > I am not sure what you are getting at here. kernel.h does not include > kern_levels.h (but printk.h does). I, for one, am always happier when > necessary include files are explicitly included. kernel.h -> printk.h -> kern_levels.h No .c file in the tree does a specific #include of kern_levels.h, only a couple of .S files. Adding printk.h might be useful, but I think that kernel.h is probably better.