From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752659AbbCWPnR (ORCPT ); Mon, 23 Mar 2015 11:43:17 -0400 Received: from smtprelay0188.hostedemail.com ([216.40.44.188]:37067 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752144AbbCWPnO (ORCPT ); Mon, 23 Mar 2015 11:43:14 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1567:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3865:3867:3870:3871:3872:3873:3874:4250:4321:5007:6261:10004:10400:10848:11232:11658:11914:12043:12517:12519:12740:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: skin19_38f83e10dd315 X-Filterd-Recvd-Size: 1550 Message-ID: <1427125389.16851.23.camel@perches.com> Subject: Re: [PATCH -next] netfilter: Use LOGLEVEL_ defines From: Joe Perches To: Pablo Neira Ayuso Cc: Stephen Rothwell , David Miller , netdev@vger.kernel.org, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Patrick McHardy Date: Mon, 23 Mar 2015 08:43:09 -0700 In-Reply-To: <20150323135235.GA7595@salvia> References: <20150323140841.0b807b95@canb.auug.org.au> <20150323124723.GA6740@salvia> <1427115331.16851.11.camel@perches.com> <20150323130638.GA6857@salvia> <1427117031.16851.16.camel@perches.com> <20150324003828.0eac53d9@canb.auug.org.au> <20150323135235.GA7595@salvia> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-03-23 at 14:52 +0100, Pablo Neira Ayuso wrote: > I would also prefer if you include the explicit header files in that > patch too. Could you send us a v2? Please, Cc: > netfilter-devel@vger.kernel.org As I wrote to Stephen, I'd prefer to #include kernel.h where it's not already specified. net/netfilter/nft_log.c does, every other modified file doesn't. Is that OK with you?