public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Jim Kukunas <james.t.kukunas@linux.intel.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
	tom.zanussi@linux.intel.com,
	Arjan van de Ven <arjan@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	tglx@linutronix.de, mingo@redhat.com, x86@kernel.org
Subject: Re: [PATCH 10/11] x86/xip: resolve alternative instructions at build
Date: Mon, 23 Mar 2015 23:40:29 +0100	[thread overview]
Message-ID: <1427150429.10958.12.camel@x220> (raw)
In-Reply-To: <1427096800-30452-11-git-send-email-james.t.kukunas@linux.intel.com>

Whitespace nits, mainly, I'm afraid.

On Mon, 2015-03-23 at 00:46 -0700, Jim Kukunas wrote:
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig

> +menu "XIP Alternative Instructions"
> +	depends on XIP_KERNEL
> +
> +	config XIP_ENABLE_X86_FEATURE_POPCNT

No need to indent this line.

> +	bool "Enable POPCNT alternative instructions"
> +	default n
> +
> +	config XIP_ENABLE_X86_BUG_11AP

Ditto.

> +	bool "Enable 11AP alternative instructions"
> +	default n
> +
> +	config XIP_ENABLE_X86_FEATURE_XMM2

Etc.

> +	bool "Enable XMM2 alternative instructions"
> +	default n
> +
> +	config XIP_ENABLE_X86_FEATURE_MFENCE_RDTSC
> +	bool "Enable MFENCE_RDTSC alternative instructions"
> +	default n
> +
> +	config XIP_ENABLE_X86_FEATURE_LFENCE_RDTSC
> +	bool "Enable LFENCE_RDTSC alternative instructions"
> +	default n
> +
> +	config XIP_ENABLE_X86_FEATURE_3DNOW
> +	bool "Enable 3DNOW alternative instructions"
> +	default n
> +
> +	config XIP_ENABLE_X86_FEATURE_XMM
> +	bool "Enabled XMM alternative instructions"
> +	default n
> +
> +	config XIP_ENABLE_X86_FEATURE_CLFLUSHOPT
> +	bool "Enable CLFLUSHOPT alternative instructions"
> +	default n
> +
> +	config XIP_ENABLE_X86_FEATURE_XSAVEOPT
> +	bool "Enable XSAVEOPT alternative instructions"
> +	default n
> +
> +	config XIP_ENABLE_X86_FEATURE_XSAVES
> +	bool "Enable XSAVES alternative instructions"
> +	default n
> +
> +endmenu
> +

The "n  defaults are probably unneeded too.


Paul Bolle


  parent reply	other threads:[~2015-03-23 22:40 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-23  7:46 [RFC] x86 XIP Jim Kukunas
2015-03-23  7:46 ` [PATCH 01/11] x86/xip: add XIP_KERNEL and XIP_BASE options Jim Kukunas
2015-03-23  7:46 ` [PATCH 02/11] x86/xip: Update address of sections in linker script Jim Kukunas
2015-03-23  7:46 ` [PATCH 03/11] x86/xip: copy writable sections into RAM Jim Kukunas
2015-03-23  7:46 ` [PATCH 04/11] x86/xip: XIP boot trampoline page tables Jim Kukunas
2015-03-23  7:46 ` [PATCH 05/11] x86/xip: reserve memblock for only data Jim Kukunas
2015-03-23  7:46 ` [PATCH 06/11] x86/xip: after paging trampoline, discard PMDs above _brk Jim Kukunas
2015-03-23  7:46 ` [PATCH 07/11] x86/xip: make e820_add_kernel_range() a NOP Jim Kukunas
2015-03-23  7:46 ` [PATCH 08/11] x86/xip: in setup_arch(), handle resource physical addr Jim Kukunas
2015-03-23  7:46 ` [PATCH 09/11] x86/xip: snip the kernel text out of the memory mapping Jim Kukunas
2015-03-23  7:46 ` [PATCH 10/11] x86/xip: resolve alternative instructions at build Jim Kukunas
2015-03-23  8:33   ` Borislav Petkov
2015-03-23  8:38     ` Borislav Petkov
2015-03-25  0:50     ` Jim Kukunas
2015-03-25  8:44       ` Borislav Petkov
2015-03-23 22:40   ` Paul Bolle [this message]
2015-03-23  7:46 ` [PATCH 11/11] x86/xip: update _va() and _pa() macros Jim Kukunas
2015-03-23  8:09   ` Ingo Molnar
2015-03-23 15:09     ` Borislav Petkov
2015-03-23  8:07 ` [RFC] x86 XIP Ingo Molnar
2015-03-25  0:14   ` Jim Kukunas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427150429.10958.12.camel@x220 \
    --to=pebolle@tiscali.nl \
    --cc=arjan@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=james.t.kukunas@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=tom.zanussi@linux.intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox