From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753474AbbCXOMN (ORCPT ); Tue, 24 Mar 2015 10:12:13 -0400 Received: from smtprelay0091.hostedemail.com ([216.40.44.91]:34893 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752516AbbCXOMJ (ORCPT ); Tue, 24 Mar 2015 10:12:09 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2194:2199:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3354:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4321:5007:6261:6691:7903:8660:9010:9036:10004:10400:10848:11232:11473:11658:11914:12517:12519:12555:12740:13069:13148:13230:13311:13357:14096:14097:21063:21067:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: death10_2e665e5ee323f X-Filterd-Recvd-Size: 2739 Message-ID: <1427206317.5642.18.camel@perches.com> Subject: Re: [PATCH] checkpatch: remove unneeded or ("|") From: Joe Perches To: Christian Borntraeger Cc: Andy Whitcroft , linux-kernel@vger.kernel.org, Andrew Morton Date: Tue, 24 Mar 2015 07:11:57 -0700 In-Reply-To: <55115093.7040605@de.ibm.com> References: <1426169269-15332-1-git-send-email-borntraeger@de.ibm.com> <1426169615.32696.103.camel@perches.com> <20150312145631.GT6998@bark> <55115093.7040605@de.ibm.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-03-24 at 12:54 +0100, Christian Borntraeger wrote: > Am 12.03.2015 um 15:56 schrieb Andy Whitcroft: > > On Thu, Mar 12, 2015 at 07:13:35AM -0700, Joe Perches wrote: > >> On Thu, 2015-03-12 at 15:07 +0100, Christian Borntraeger wrote: > >>> while porting commit 89a883530fe7 ("checkpatch: ## is not a valid > >>> modifier") to QEMU, Peter Maydell noticed that the | at the end of > >>> the list is not necessary. > >>> > >>> Lets get rid of it in kernel checkpatch.pl > >> > >> Andy? Was that meant to allow nothing? > >> > >>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > >> [] > >>> @@ -1550,7 +1550,7 @@ sub possible { > >>> asm|__asm__| > >>> do| > >>> \#| > >>> - \#\#| > >>> + \#\# > >>> )(?:\s|$)| > >>> ^(?:typedef|struct|enum)\b > >>> )}x; > > > > Blimey you tax my memory indeed. > > > > The two places it is used we are saying that the strings which match are > > not modifiers. So it seems sane that we would want to reject the empty > > string in that case. That said, it does not appear any of the callers > > would call with a blank string. I would suggest we had it like that as > > a safety feature, _though_ if we had I would have expected it to have a > > nice shiney comment to say just how smart we being using that trailing > > or and so likely as not is is unintentional. > > > > tl;dr I think it is safe to elide it with the current callers, it being > > there seems safe, but if it stays damn it should have a comment to say > > its a safety net and not just hide out. > > > > -apw > > > > So how to proceed? > Take my patch, drop my patch or rework my patch? If Andy acks it, I suggest sending it again along with Andy's ack, to Andrew Morton (cc'd)