From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932312AbbCXQMM (ORCPT ); Tue, 24 Mar 2015 12:12:12 -0400 Received: from mga14.intel.com ([192.55.52.115]:46888 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752507AbbCXQMG (ORCPT ); Tue, 24 Mar 2015 12:12:06 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,459,1422950400"; d="scan'208";a="684900751" From: "Jiang, Dave" To: "mst@redhat.com" CC: "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" , "yhlu.kernel.send@gmail.com" , "stable@vger.kernel.org" , "bhelgaas@google.com" , "jdmason@kudzu.us" , "famz@redhat.com" Subject: Re: [PATCH v3 07/10] ntb: drop pci_msi_off call on probe Thread-Topic: [PATCH v3 07/10] ntb: drop pci_msi_off call on probe Thread-Index: AQHQZkk3JgUuMz/4cESBG8PuEOUdF50sQ02A Date: Tue, 24 Mar 2015 16:12:03 +0000 Message-ID: <1427213523.221225.30.camel@intel.com> References: <1427211032-2270-1-git-send-email-mst@redhat.com> <1427211032-2270-8-git-send-email-mst@redhat.com> In-Reply-To: <1427211032-2270-8-git-send-email-mst@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.2.105.47] Content-Type: text/plain; charset="utf-8" Content-ID: <66754D58AAB9CA4EA355A8AE8196A50C@intel.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t2OGCGB9016315 On Tue, 2015-03-24 at 16:42 +0100, Michael S. Tsirkin wrote: > pci core now disables msi on probe automatically, > drop this from device-specific code. > > Cc: Bjorn Helgaas > Cc: linux-pci@vger.kernel.org > Signed-off-by: Michael S. Tsirkin Acked-by: Dave Jiang > --- > drivers/ntb/ntb_hw.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/ntb/ntb_hw.c b/drivers/ntb/ntb_hw.c > index cd29b10..8225cbc 100644 > --- a/drivers/ntb/ntb_hw.c > +++ b/drivers/ntb/ntb_hw.c > @@ -1313,8 +1313,6 @@ static int ntb_setup_intx(struct ntb_device *ndev) > struct pci_dev *pdev = ndev->pdev; > int rc; > > - pci_msi_off(pdev); > - > /* Verify intx is enabled */ > pci_intx(pdev, 1); > {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I