From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755222AbbCXT0I (ORCPT ); Tue, 24 Mar 2015 15:26:08 -0400 Received: from smtprelay0017.hostedemail.com ([216.40.44.17]:37412 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754434AbbCXT0F (ORCPT ); Tue, 24 Mar 2015 15:26:05 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:2895:3138:3139:3140:3141:3142:3353:3622:3865:3867:3868:3870:3871:3872:3874:4250:4321:5007:6261:10004:10400:10848:11026:11232:11473:11658:11914:12043:12296:12438:12517:12519:12740:13069:13161:13229:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: doll12_17c7ad3701a53 X-Filterd-Recvd-Size: 2681 Message-ID: <1427225161.12126.4.camel@perches.com> Subject: Re: Staging: slicoss: Fix checkpatch.pl issues From: Joe Perches To: Niranjan Dighe Cc: gregkh@linuxfoundation.org, liodot@gmail.com, charrer@alacritech.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Tue, 24 Mar 2015 12:26:01 -0700 In-Reply-To: <1427224146-7926-1-git-send-email-niranjan.dighe@gmail.com> References: <1427224146-7926-1-git-send-email-niranjan.dighe@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-03-25 at 00:39 +0530, Niranjan Dighe wrote: > The following files had coding style issues that I tried to address. > It was mostly about lines spanning more than 80 characters. [] > diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c [] > @@ -98,7 +98,8 @@ > #include "slic.h" > > static uint slic_first_init = 1; > -static char *slic_banner = "Alacritech SLIC Technology(tm) Server and Storage Accelerator (Non-Accelerated)"; > +static char *slic_banner = "Alacritech SLIC Technology(tm) Server " > + "and Storage Accelerator (Non-Accelerated)"; Please don't split strings. Maybe remove this and update the format in the one place it's used instead. > @@ -755,10 +756,10 @@ static bool slic_mac_filter(struct adapter *adapter, > > while (mcaddr) { > if (ether_addr_equal(mcaddr->address, > - ether_frame->ether_dhost)) { > - adapter->rcv_multicasts++; > - netdev->stats.multicast++; > - return true; > + ether_frame->ether_dhost)) { > + adapter->rcv_multicasts++; > + netdev->stats.multicast++; > + return true; 80 columns is a preferred limit not a hard one. The original is correct and your new indentation is not. > @@ -2561,8 +2562,9 @@ static int slic_ioctl(struct net_device *dev, struct ifreq *rq, int cmd) > DBG_IOCTL("slic_ioctl SIOCSLIC_TRACE_DUMP\n"); > > if (copy_from_user(data, rq->ifr_data, 28)) { > - PRINT_ERROR > - ("slic: copy_from_user FAILED getting initial simba param\n"); > + PRINT_ERROR( > + "slic: copy_from_user FAILED getting initial simba param\n" > + ); Just remove all the #ifdef SLIC_TRACE_DUMP_ENABLED blocks, PRINT_ERROR isn't defined anywhere. and this can't be compiled.