From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751898AbbCXU17 (ORCPT ); Tue, 24 Mar 2015 16:27:59 -0400 Received: from smtprelay0116.hostedemail.com ([216.40.44.116]:59857 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751754AbbCXU14 (ORCPT ); Tue, 24 Mar 2015 16:27:56 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:1963:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3870:3871:3872:3874:4321:5007:6261:10004:10400:10848:11026:11232:11658:11914:12043:12517:12519:12740:13069:13161:13229:13311:13357:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: laugh32_7f42f1834c20c X-Filterd-Recvd-Size: 2166 Message-ID: <1427228872.12126.8.camel@perches.com> Subject: Re: Staging: slicoss: Fix checkpatch.pl issues From: Joe Perches To: Dan Carpenter Cc: Niranjan Dighe , gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, charrer@alacritech.com, liodot@gmail.com, linux-kernel@vger.kernel.org Date: Tue, 24 Mar 2015 13:27:52 -0700 In-Reply-To: <20150324201429.GV10964@mwanda> References: <1427224146-7926-1-git-send-email-niranjan.dighe@gmail.com> <20150324201429.GV10964@mwanda> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-03-24 at 23:14 +0300, Dan Carpenter wrote: > On Wed, Mar 25, 2015 at 12:39:06AM +0530, Niranjan Dighe wrote: > > The following files had coding style issues that I tried to address. > > It was mostly about lines spanning more than 80 characters. [] > > diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c [] > > @@ -755,10 +756,10 @@ static bool slic_mac_filter(struct adapter *adapter, > > > > while (mcaddr) { > > if (ether_addr_equal(mcaddr->address, > > - ether_frame->ether_dhost)) { > > - adapter->rcv_multicasts++; > > - netdev->stats.multicast++; > > - return true; > > + ether_frame->ether_dhost)) { > > + adapter->rcv_multicasts++; > > + netdev->stats.multicast++; > > + return true; > > } > > mcaddr = mcaddr->next; > > } > > Check patch likes the new code but the original is better for human > beings. Sorry. The indentation isn't correct in the new code either. That's actually a checkpatch defect because it's not able to track deletion/insertion alignment well enough. Niranjan, checkpatch is a brainless little tool. Always use yours whenever using checkpatch.