From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752854AbbCXXXZ (ORCPT ); Tue, 24 Mar 2015 19:23:25 -0400 Received: from smtprelay0209.hostedemail.com ([216.40.44.209]:59194 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752593AbbCXXXW (ORCPT ); Tue, 24 Mar 2015 19:23:22 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:960:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3653:3865:3867:3870:3872:3873:3874:4321:5007:6261:6742:7903:10004:10400:10848:11026:11232:11658:11914:12043:12114:12438:12517:12519:12740:13069:13161:13229:13311:13357:13972:14001:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: shoe07_3a048dc544411 X-Filterd-Recvd-Size: 1929 Message-ID: <1427239395.12126.22.camel@perches.com> Subject: Re: [PATCH v3 1/9] regmap: Introduce regmap_get_max_register. From: Joe Perches To: Srinivas Kandagatla Cc: Mark Brown , linux-arm-kernel@lists.infradead.org, Maxime Ripard , Rob Herring , Kumar Gala , Greg Kroah-Hartman , linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, arnd@arndb.de, sboyd@codeaurora.org Date: Tue, 24 Mar 2015 16:23:15 -0700 In-Reply-To: <5511EDD7.40202@linaro.org> References: <1427236116-18531-1-git-send-email-srinivas.kandagatla@linaro.org> <1427236179-18580-1-git-send-email-srinivas.kandagatla@linaro.org> <20150324223637.GB28997@sirena.org.uk> <5511EDD7.40202@linaro.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-03-24 at 23:05 +0000, Srinivas Kandagatla wrote: > On 24/03/15 22:36, Mark Brown wrote: > >> +int regmap_get_max_register(struct regmap *map) > >> +{ > >> + return map->max_register ? : -EINVAL; > >> +} > > > > Please write the logic out properly, don't abuse the ternery operator. > Am happy to change it to your preference in next version, but this GNU > extensions widely used in the kernel > > $ grep -rR "return.*? :" ./linux | wc -l > 115 Double that when you add the ?: variants $ git grep -E "return.*\?\s*:" | wc -l 253 There are ~530 uses like: return ? :