From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752763AbbCYUPJ (ORCPT ); Wed, 25 Mar 2015 16:15:09 -0400 Received: from lb1-smtp-cloud2.xs4all.net ([194.109.24.21]:51242 "EHLO lb1-smtp-cloud2.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752707AbbCYUPG (ORCPT ); Wed, 25 Mar 2015 16:15:06 -0400 Message-ID: <1427314499.10958.36.camel@x220> Subject: Re: [PATCH 1/3] iio: configfs: Add configfs support to IIO From: Paul Bolle To: Daniel Baluta Cc: jic23@kernel.org, jlbec@evilplan.org, lars@metafoo.de, knaack.h@gmx.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, octavian.purdila@intel.com Date: Wed, 25 Mar 2015 21:14:59 +0100 In-Reply-To: <1427302832-9336-2-git-send-email-daniel.baluta@intel.com> References: <1427302832-9336-1-git-send-email-daniel.baluta@intel.com> <1427302832-9336-2-git-send-email-daniel.baluta@intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A license nit. On Wed, 2015-03-25 at 19:00 +0200, Daniel Baluta wrote: > --- /dev/null > +++ b/drivers/iio/industrialio-configfs.c > + * This program is free software; you can redistribute it and/or modify it > + * under the terms of the GNU General Public License version 2 as published by > + * the Free Software Foundation. > +MODULE_AUTHOR("Daniel Baluta "); > +MODULE_DESCRIPTION("Industrial I/O configfs support"); You probably want MODULE_LICENSE("GPL v2"); here too. Because now, at module load time, the license will default to "unspecified" which will taint the kernel. Paul Bolle