From: Namhyung Kim <namhyung@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>,
Shuah Khan <shuahkh@osg.samsung.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Dave Jones <davej@codemonkey.org.uk>,
Luis Henriques <luis.henriques@canonical.com>
Subject: [PATCH] ftracetest: Do not use usleep
Date: Thu, 26 Mar 2015 09:32:23 +0900 [thread overview]
Message-ID: <1427329943-16896-1-git-send-email-namhyung@kernel.org> (raw)
The usleep is only provided on distros from Redhat so running ftracetest
on other distro resulted in failures due to the missing usleep.
The reason of using [u]sleep in the test was to generate (scheduler)
events. But as we use 'cat trace | grep | wc -l' to read the events,
the command themselves already generate some events before reading the
trace file so no need to call [u]sleep explicitly.
Reported-by: Michael Ellerman <mpe@ellerman.id.au>
Reported-by: Dave Jones <davej@codemonkey.org.uk>
Reported-by: Luis Henriques <luis.henriques@canonical.com>
Tested-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/testing/selftests/ftrace/test.d/event/event-enable.tc | 3 ---
tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc | 3 ---
2 files changed, 6 deletions(-)
diff --git a/tools/testing/selftests/ftrace/test.d/event/event-enable.tc b/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
index 668616d9bb03..7c7b4ce383a3 100644
--- a/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
+++ b/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
@@ -21,7 +21,6 @@ reset_tracer
do_reset
echo 'sched:sched_switch' > set_event
-usleep 1
count=`cat trace | grep sched_switch | wc -l`
if [ $count -eq 0 ]; then
@@ -31,7 +30,6 @@ fi
do_reset
echo 1 > events/sched/sched_switch/enable
-usleep 1
count=`cat trace | grep sched_switch | wc -l`
if [ $count -eq 0 ]; then
@@ -41,7 +39,6 @@ fi
do_reset
echo 0 > events/sched/sched_switch/enable
-usleep 1
count=`cat trace | grep sched_switch | wc -l`
if [ $count -ne 0 ]; then
diff --git a/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc b/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc
index 655c415b6e7f..08a9459224b0 100644
--- a/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc
+++ b/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc
@@ -21,7 +21,6 @@ reset_tracer
do_reset
echo 'sched:*' > set_event
-usleep 1
count=`cat trace | grep -v ^# | awk '{ print $5 }' | sort -u | wc -l`
if [ $count -lt 3 ]; then
@@ -31,7 +30,6 @@ fi
do_reset
echo 1 > events/sched/enable
-usleep 1
count=`cat trace | grep -v ^# | awk '{ print $5 }' | sort -u | wc -l`
if [ $count -lt 3 ]; then
@@ -41,7 +39,6 @@ fi
do_reset
echo 0 > events/sched/enable
-usleep 1
count=`cat trace | grep -v ^# | awk '{ print $5 }' | sort -u | wc -l`
if [ $count -ne 0 ]; then
--
2.3.3
next reply other threads:[~2015-03-26 0:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 0:32 Namhyung Kim [this message]
2015-03-30 20:47 ` [PATCH] ftracetest: Do not use usleep Shuah Khan
2015-03-30 21:15 ` Steven Rostedt
2015-03-31 0:48 ` Namhyung Kim
2015-03-31 1:04 ` Steven Rostedt
2015-03-31 1:08 ` Pádraig Brady
2015-03-31 1:29 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427329943-16896-1-git-send-email-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=davej@codemonkey.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=luis.henriques@canonical.com \
--cc=mpe@ellerman.id.au \
--cc=rostedt@goodmis.org \
--cc=shuahkh@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox