From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752238AbbCZJvk (ORCPT ); Thu, 26 Mar 2015 05:51:40 -0400 Received: from ns.mm-sol.com ([37.157.136.199]:33124 "EHLO extserv.mm-sol.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751930AbbCZJvi (ORCPT ); Thu, 26 Mar 2015 05:51:38 -0400 Message-ID: <1427363493.7093.4.camel@mm-sol.com> Subject: Re: [PATCH V5 0/2] add support for pmic_arb v2 and correct framework From: "Ivan T. Ivanov" To: Gilad Avidov , "Gala, Kumar" Cc: sdharia@codeaurora.org, mlocke@codeaurora.org, linux-arm-msm@vger.kernel.org, gregkh@linuxfoundation.org, svarbanov@mm-sol.com, linux-kernel@vger.kernel.org, galak@codeaurora.org, agross@codeaurora.org Date: Thu, 26 Mar 2015 11:51:33 +0200 In-Reply-To: <1427305052-1284-1-git-send-email-gavidov@codeaurora.org> References: <1427305052-1284-1-git-send-email-gavidov@codeaurora.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.13.7-fta1.2~trusty Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-03-25 at 11:37 -0600, Gilad Avidov wrote: > pmic_arb v2 has no support for spmi non-data commands and thus > returns -EOPNOTSUPP on .cmd callback. This causes a failure in > spmi_drv_probe() which sends a wakeup command to the slave before > probing its driver. This patchset removes the wakeup from > spmi_drv_probe() since the spmi spec stipulates that a slaves > default state is active and doesn't need a wakeup. > > Changes from v3 to v4: > * Remove the claim that this is a bug fix off the commit text > * Unmap the core register space as soon as we know that it will not be used > * Assign the core reg space to a local until we know if it appropriate to use > it to configure the controller fields (on v1) or unmap it (on v2). > > Changes from v4 to v5: > * remove the unmap added in v4 since it is used again and the mapping is managed. > * correct printf formatting for 64bit compilers. > * correct base address for reading the channel table. > > Gilad Avidov (2): > spmi: remove wakeup command before slave probe > spmi: pmic_arb: add support for hw version 2 Thank you Gilad. This is fine now. Tested on APQ8084 (controller v1) and MSM8916 (controller v2). I am wandering which is the appropriate tree to merge this? Kumar? Tested-by: Ivan T. Ivanov