Re: [PATCH 1/1] perf/x86: filter branches for PEBS event

Peter Zijlstra
2015-03-27T12:17:55Z

On Thu, Mar 26, 2015 at 02:13:23PM -0400, kan.liang@intel.com wrote:
> This patch move intel_shared_regs_constraints for branch_reg ahead of
> intel_pebs_constraints.

Why not all shared regs?

> intel_shared_regs_constraints for branch_reg doesn't modify event->hw,
> so it's safe to be called before intel_pebs_constraints.
> intel_shared_regs_constraints for branch_reg also special case when it
> returns &emptyconstraint. It put constraints for extra_reg. This patch
> remove it. Because it will never get constraints for extra_reg if return
> is &emptyconstraint.

-ENOPARSE.