From: Joe Perches <joe@perches.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Niranjan Dighe <niranjan.dighe@gmail.com>,
devel@driverdev.osuosl.org, charrer@alacritech.com,
liodot@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] Staging: slicoss: Get rid of redundant pointer variable
Date: Thu, 26 Mar 2015 13:52:33 -0700 [thread overview]
Message-ID: <1427403153.15849.18.camel@perches.com> (raw)
In-Reply-To: <20150326185231.GA3385@kroah.com>
On Thu, 2015-03-26 at 19:52 +0100, Greg KH wrote:
> On Thu, Mar 26, 2015 at 11:52:43PM +0530, Niranjan Dighe wrote:
> > Replace string directly in place of format string and remove pointer
> > variable which was used just once.
[]
> > diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
[]
> > @@ -3046,7 +3045,8 @@ static int slic_entry_probe(struct pci_dev *pcidev,
> > return err;
> >
> > if (did_version++ == 0) {
> > - dev_info(&pcidev->dev, "%s\n", slic_banner);
> > + dev_info(&pcidev->dev,
> > + "Alacritech SLIC Technology(tm) Server and Storage Accelerator (Non-Accelerated)\n");
>
> Why make this change? What's wrong with the original code?
>
> There is the issue that driver should be quiet, so really, you can just
> delete all of this nonsense, but that's a different issue here...
You could also use dev_info_once instead.
next prev parent reply other threads:[~2015-03-26 20:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 19:58 [PATCH] Staging: slicoss: Fix checkpatch.pl issues Niranjan Dighe
2015-03-26 12:12 ` Greg KH
2015-03-26 18:21 ` [PATCH v2 1/2] Staging: slicoss: Remove redundant and disabled code block Niranjan Dighe
2015-03-26 18:22 ` [PATCH v2 2/2] Staging: slicoss: Get rid of redundant pointer variable Niranjan Dighe
2015-03-26 18:33 ` Dan Carpenter
2015-03-26 18:52 ` Greg KH
2015-03-26 20:52 ` Joe Perches [this message]
2015-03-26 21:32 ` Greg KH
2015-03-26 21:42 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427403153.15849.18.camel@perches.com \
--to=joe@perches.com \
--cc=charrer@alacritech.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liodot@gmail.com \
--cc=niranjan.dighe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox