From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752882AbbCZUwj (ORCPT ); Thu, 26 Mar 2015 16:52:39 -0400 Received: from smtprelay0146.hostedemail.com ([216.40.44.146]:58462 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752160AbbCZUwh (ORCPT ); Thu, 26 Mar 2015 16:52:37 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3868:3870:3871:3873:3874:4250:4321:5007:6119:6261:10004:10400:10848:11026:11232:11658:11914:12043:12296:12517:12519:12740:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: kick90_1681a8a05ab20 X-Filterd-Recvd-Size: 1885 Message-ID: <1427403153.15849.18.camel@perches.com> Subject: Re: [PATCH v2 2/2] Staging: slicoss: Get rid of redundant pointer variable From: Joe Perches To: Greg KH Cc: Niranjan Dighe , devel@driverdev.osuosl.org, charrer@alacritech.com, liodot@gmail.com, linux-kernel@vger.kernel.org Date: Thu, 26 Mar 2015 13:52:33 -0700 In-Reply-To: <20150326185231.GA3385@kroah.com> References: <20150326121203.GA22363@kroah.com> <1427394163-3074-1-git-send-email-niranjan.dighe@gmail.com> <20150326185231.GA3385@kroah.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-03-26 at 19:52 +0100, Greg KH wrote: > On Thu, Mar 26, 2015 at 11:52:43PM +0530, Niranjan Dighe wrote: > > Replace string directly in place of format string and remove pointer > > variable which was used just once. [] > > diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c [] > > @@ -3046,7 +3045,8 @@ static int slic_entry_probe(struct pci_dev *pcidev, > > return err; > > > > if (did_version++ == 0) { > > - dev_info(&pcidev->dev, "%s\n", slic_banner); > > + dev_info(&pcidev->dev, > > + "Alacritech SLIC Technology(tm) Server and Storage Accelerator (Non-Accelerated)\n"); > > Why make this change? What's wrong with the original code? > > There is the issue that driver should be quiet, so really, you can just > delete all of this nonsense, but that's a different issue here... You could also use dev_info_once instead.