From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932156AbbCZVmQ (ORCPT ); Thu, 26 Mar 2015 17:42:16 -0400 Received: from smtprelay0096.hostedemail.com ([216.40.44.96]:33948 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932134AbbCZVmN (ORCPT ); Thu, 26 Mar 2015 17:42:13 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:968:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1535:1544:1593:1594:1711:1730:1747:1777:1792:2375:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3354:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4250:4321:4605:5007:6119:6261:7875:7903:7974:10004:10848:11026:11232:11473:11658:11914:12043:12296:12517:12519:12740:13161:13229:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: level59_1203a3e66243f X-Filterd-Recvd-Size: 5116 Message-ID: <1427406122.15849.22.camel@perches.com> Subject: Re: [PATCH v2 2/2] Staging: slicoss: Get rid of redundant pointer variable From: Joe Perches To: Greg KH Cc: Niranjan Dighe , devel@driverdev.osuosl.org, charrer@alacritech.com, liodot@gmail.com, linux-kernel@vger.kernel.org Date: Thu, 26 Mar 2015 14:42:02 -0700 In-Reply-To: <20150326213258.GA27434@kroah.com> References: <20150326121203.GA22363@kroah.com> <1427394163-3074-1-git-send-email-niranjan.dighe@gmail.com> <20150326185231.GA3385@kroah.com> <1427403153.15849.18.camel@perches.com> <20150326213258.GA27434@kroah.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-03-26 at 22:32 +0100, Greg KH wrote: > On Thu, Mar 26, 2015 at 01:52:33PM -0700, Joe Perches wrote: > > On Thu, 2015-03-26 at 19:52 +0100, Greg KH wrote: > > > On Thu, Mar 26, 2015 at 11:52:43PM +0530, Niranjan Dighe wrote: > > > > Replace string directly in place of format string and remove pointer > > > > variable which was used just once. > > [] > > > > diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c > > [] > > > > @@ -3046,7 +3045,8 @@ static int slic_entry_probe(struct pci_dev *pcidev, > > > > return err; > > > > > > > > if (did_version++ == 0) { > > > > - dev_info(&pcidev->dev, "%s\n", slic_banner); > > > > + dev_info(&pcidev->dev, > > > > + "Alacritech SLIC Technology(tm) Server and Storage Accelerator (Non-Accelerated)\n"); > > > > > > Why make this change? What's wrong with the original code? > > > > > > There is the issue that driver should be quiet, so really, you can just > > > delete all of this nonsense, but that's a different issue here... > > > > You could also use dev_info_once instead. > > No, drivers shouldn't make any noise when loaded, or when bound to a > device, that's just fluff that is not needed, and is why we made the > default module load macros to help prevent that from happening. Looks > like people really wanted to be chatty here and tried to do it in their > probe function instead :( > > Just delete it. There are many probe functions that emit messages in the tree. Most of the _once functions. Maybe someone can delete those too. $ git grep -E "\b[a-z_]+_once\s*\(.*(version|banner)" drivers drivers/block/sx8.c: printk_once(KERN_DEBUG DRV_NAME " version " DRV_VERSION "\n"); drivers/infiniband/hw/cxgb3/iwch.c: printk_once(KERN_INFO MOD "Chelsio T3 RDMA Driver - version %s\n", drivers/infiniband/hw/mlx4/main.c: pr_info_once("%s", mlx4_ib_version); drivers/infiniband/hw/mlx5/main.c: printk_once(KERN_INFO "%s", mlx5_version); drivers/infiniband/hw/mthca/mthca_main.c: printk_once(KERN_INFO "%s", mthca_version); drivers/infiniband/hw/usnic/usnic_ib_main.c: printk_once(KERN_INFO "%s", usnic_version); drivers/net/ethernet/8390/mac8390.c: printk_once(KERN_INFO pr_fmt("%s"), version); drivers/net/ethernet/amd/au1000_eth.c: pr_info_once("%s version %s %s\n", DRV_NAME, DRV_VERSION, DRV_AUTHOR); drivers/net/ethernet/broadcom/b44.c: pr_info_once("%s version %s\n", DRV_DESCRIPTION, DRV_MODULE_VERSION); drivers/net/ethernet/broadcom/tg3.c: printk_once(KERN_INFO "%s\n", version); drivers/net/ethernet/chelsio/cxgb/cxgb2.c: pr_info_once("%s - version %s\n", DRV_DESCRIPTION, DRV_VERSION); drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c: pr_info_once("%s - version %s\n", DRV_DESC, DRV_VERSION); drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c: printk_once(KERN_INFO "%s - version %s\n", DRV_DESC, DRV_VERSION); drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c: pr_info_once("%s - version %s\n", DRV_DESC, DRV_VERSION); drivers/net/ethernet/cirrus/cs89x0.c: pr_info_once("%s\n", version); drivers/net/ethernet/dec/tulip/tulip_core.c: printk_once(KERN_INFO "%s", version); drivers/net/ethernet/mellanox/mlx4/en_main.c: printk_once(KERN_INFO "%s", mlx4_en_version); drivers/net/ethernet/mellanox/mlx4/main.c: printk_once(KERN_INFO "%s", mlx4_version); drivers/net/ethernet/realtek/8139cp.c: pr_info_once("%s", version); drivers/net/ethernet/smsc/epic100.c: pr_info_once("%s%s\n", version, version2); drivers/net/ethernet/smsc/smc9194.c: pr_info_once("%s\n", version); drivers/net/ethernet/smsc/smc91x.c: pr_info_once("%s\n", version); drivers/net/ethernet/sun/sungem.c: printk_once(KERN_INFO "%s", version); drivers/net/ethernet/sun/sunvnet.c: printk_once(KERN_INFO "%s", version); drivers/net/ethernet/via/via-rhine.c: pr_info_once("%s\n", version); drivers/net/wan/sbni.c: pr_info_once("%s", version); drivers/net/wan/wanxl.c: pr_info_once("%s\n", version);