From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752756AbbC0NFR (ORCPT ); Fri, 27 Mar 2015 09:05:17 -0400 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:44930 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752310AbbC0NFP (ORCPT ); Fri, 27 Mar 2015 09:05:15 -0400 Message-ID: <1427461506.2250.19.camel@HansenPartnership.com> Subject: Re: [PATCH v7 2/3] scsi: ufs: add debugfs for ufs From: James Bottomley To: Gilad Broner Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org, santoshsy@gmail.com, linux-scsi-owner@vger.kernel.org, subhashj@codeaurora.org, ygardi@codeaurora.org, draviv@codeaurora.org, Lee Susman , Raviv Shvili , Vinayak Holikatti Date: Fri, 27 Mar 2015 14:05:06 +0100 In-Reply-To: <1426175700-23152-3-git-send-email-gbroner@codeaurora.org> References: <1426175700-23152-1-git-send-email-gbroner@codeaurora.org> <1426175700-23152-3-git-send-email-gbroner@codeaurora.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-03-12 at 17:54 +0200, Gilad Broner wrote: > From: Lee Susman > > Adding debugfs capability for ufshcd. This patch fails to build as a module because you aren't building corectly: ERROR: "ufsdbg_add_debugfs" [drivers/scsi/ufs/ufshcd.ko] undefined! ERROR: "ufsdbg_remove_debugfs" [drivers/scsi/ufs/ufshcd.ko] undefined! scripts/Makefile.modpost:90: recipe for target '__modpost' failed CONFIG_DEBUG_FS is y in my system not m, so your Makefile fails. James