From: "M. Vefa Bicakci" <m.v.b@runbox.com>
To: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Cc: gregkh@linuxfoundation.org, Jes.Sorensen@redhat.com,
joe@perches.com, Larry.Finger@lwfinger.net,
mail@beyermatthias.de, m.v.b@runbox.com
Subject: [PATCH v4 07/15] staging: rtl8723au: Remove unneeded curly braces
Date: Sat, 28 Mar 2015 08:52:40 -0400 [thread overview]
Message-ID: <1427547168-12078-8-git-send-email-m.v.b@runbox.com> (raw)
In-Reply-To: <1427547168-12078-1-git-send-email-m.v.b@runbox.com>
Correct a number of checkpatch.pl warnings in rtl8723au's rtw_security.c
related to the existence of unnecessary curly braces around single
statement blocks:
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: M. Vefa Bicakci <m.v.b@runbox.com>
---
drivers/staging/rtl8723au/core/rtw_security.c | 16 +++++-----------
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_security.c b/drivers/staging/rtl8723au/core/rtw_security.c
index f7571cf091..b4327aaf71 100644
--- a/drivers/staging/rtl8723au/core/rtw_security.c
+++ b/drivers/staging/rtl8723au/core/rtw_security.c
@@ -113,9 +113,8 @@ static void crc32_init(void)
for (i = 0; i < 256; ++i) {
k = crc32_reverseBit((u8)i);
- for (c = ((u32)k) << 24, j = 8; j > 0; --j) {
+ for (c = ((u32)k) << 24, j = 8; j > 0; --j)
c = c & 0x80000000 ? (c << 1) ^ CRC32_POLY : (c << 1);
- }
p1 = (u8 *)&crc32_table[i];
@@ -267,9 +266,8 @@ static u32 secmicgetuint32(u8 *p)
s32 i;
u32 res = 0;
- for (i = 0; i < 4; i++) {
+ for (i = 0; i < 4; i++)
res |= ((u32)(*p++)) << (8 * i);
- }
return res;
}
@@ -353,9 +351,8 @@ void rtw_secgetmic23a(struct mic_data *pmicdata, u8 *dst)
rtw_secmicappend23abyte23a(pmicdata, 0);
rtw_secmicappend23abyte23a(pmicdata, 0);
/* and then zeroes until the length is a multiple of 4 */
- while (pmicdata->nBytesInM != 0) {
+ while (pmicdata->nBytesInM != 0)
rtw_secmicappend23abyte23a(pmicdata, 0);
- }
/* The appendByte function has already computed the result. */
secmicputuint32(dst, pmicdata->L);
secmicputuint32(dst + 4, pmicdata->R);
@@ -871,10 +868,8 @@ static void byte_sub(u8 *in, u8 *out)
{
int i;
- for (i = 0; i < 16; i++) {
+ for (i = 0; i < 16; i++)
out[i] = sbox(in[i]);
- }
-
}
static void shift_row(u8 *in, u8 *out)
@@ -935,9 +930,8 @@ static void mix_column(u8 *in, u8 *out)
for (i = 3; i > 0; i--) { /* logical shift left 1 bit */
andf7[i] = andf7[i] << 1;
- if ((andf7[i - 1] & 0x80) == 0x80) {
+ if ((andf7[i - 1] & 0x80) == 0x80)
andf7[i] = (andf7[i] | 0x01);
- }
}
andf7[0] = andf7[0] << 1;
andf7[0] = andf7[0] & 0xfe;
--
2.1.4
next prev parent reply other threads:[~2015-03-28 12:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-28 12:52 [PATCH v4 00/15] checkpatch clean-up of rtl8723au's rtw_security.c M. Vefa Bicakci
2015-03-28 12:52 ` [PATCH v4 01/15] staging: rtl8723au: Reformat whitespace to increase readability M. Vefa Bicakci
2015-03-28 12:52 ` [PATCH v4 02/15] staging: rtl8723au: Fix "before/around/after" whitespace issues M. Vefa Bicakci
2015-03-28 12:52 ` [PATCH v4 03/15] staging: rtl8723au: else should follow close brace M. Vefa Bicakci
2015-03-28 12:52 ` [PATCH v4 04/15] staging: rtl8723au: Fix the indentation of two lines M. Vefa Bicakci
2015-03-28 12:52 ` [PATCH v4 05/15] staging: rtl8723au: Reorganize a few functions to remove indentation M. Vefa Bicakci
2015-03-28 12:52 ` [PATCH v4 06/15] staging: rtl8723au: else is not generally useful after a return M. Vefa Bicakci
2015-03-28 12:52 ` M. Vefa Bicakci [this message]
2015-03-28 12:52 ` [PATCH v4 08/15] staging: rtl8723au: trailing statements should be on next line M. Vefa Bicakci
2015-03-28 12:52 ` [PATCH v4 09/15] staging: rtl8723au: that open brace should be on the previous line M. Vefa Bicakci
2015-03-28 12:52 ` [PATCH v4 10/15] staging: rtl8723au: No spaces at the start of a line M. Vefa Bicakci
2015-03-28 12:52 ` [PATCH v4 11/15] staging: rtl8723au: Adjust whitespace in and around comments M. Vefa Bicakci
2015-03-28 12:52 ` [PATCH v4 12/15] staging: rtl8723au: suspect code indent for conditional statements M. Vefa Bicakci
2015-03-28 12:52 ` [PATCH v4 13/15] staging: rtl8723au: Rework two byte array comparisons M. Vefa Bicakci
2015-03-28 12:52 ` [PATCH v4 14/15] staging: rtl8723au: Use __func__ in trace logs M. Vefa Bicakci
2015-03-28 12:52 ` [PATCH v4 15/15] staging: rtl8723au: Remove unneeded comments M. Vefa Bicakci
2015-03-28 19:52 ` [PATCH v4 00/15] checkpatch clean-up of rtl8723au's rtw_security.c Joe Perches
2015-03-28 23:58 ` M. Vefa Bicakci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427547168-12078-8-git-send-email-m.v.b@runbox.com \
--to=m.v.b@runbox.com \
--cc=Jes.Sorensen@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mail@beyermatthias.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox