From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752437AbbC1Vf1 (ORCPT <rfc822;w@1wt.eu>);
	Sat, 28 Mar 2015 17:35:27 -0400
Received: from smtprelay0100.hostedemail.com ([216.40.44.100]:55531 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1752259AbbC1Vf0 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 28 Mar 2015 17:35:26 -0400
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:966:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2196:2199:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3871:3872:3874:4321:4385:5007:6261:6742:7514:7903:9036:9040:10004:10400:10848:11232:11473:11658:11914:12296:12517:12519:12740:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0
X-HE-Tag: bun18_4bdb272877639
X-Filterd-Recvd-Size: 2662
Message-ID: <1427578519.2715.13.camel@perches.com>
Subject: Re: [PATCH] staging: speakup: Fix warning of line over 80
 characters.
From: Joe Perches <joe@perches.com>
To: Richard Weinberger <richard@nod.at>
Cc: Shirish Gajera <gshirishfree@gmail.com>, w.d.hubbs@gmail.com,
        chris@the-brannons.com, kirk@reisers.ca, samuel.thibault@ens-lyon.org,
        Greg KH <gregkh@linuxfoundation.org>,
        Domagoj =?UTF-8?Q?Tr=C5=A1an?= <domagoj.trsan@gmail.com>,
        mahfouz.saif.elyazal@gmail.com, Ben Hutchings <ben@decadent.org.uk>,
        roxanagabriela10@gmail.com, Robin Schroer <sulamiification@gmail.com>,
        dilekuzulmez@gmail.com, DaeSeok Youn <daeseok.youn@gmail.com>,
        =?UTF-8?Q?Ay=C5=9Fe?= Melike =?UTF-8?Q?Yurto=C4=9Flu?= 
	<aysemelikeyurtoglu@gmail.com>,
        Rusty Russell <rusty@rustcorp.com.au>, tapaswenipathak@gmail.com,
        vthakkar1994@gmail.com, speakup@linux-speakup.org,
        "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        LKML <linux-kernel@vger.kernel.org>
Date: Sat, 28 Mar 2015 14:35:19 -0700
In-Reply-To: <55171BAF.9050405@nod.at>
References: <20150328202139.GA12695@shirish-ThinkPad-Edge-E430>
	 <CAFLxGvyG0nAF=+g=OusJj79BO1iFiU=E2w-0_Vyz2djHv1_=Sg@mail.gmail.com>
	 <1427577518.2715.8.camel@perches.com> <55171BAF.9050405@nod.at>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, 2015-03-28 at 22:22 +0100, Richard Weinberger wrote:
> Am 28.03.2015 um 22:18 schrieb Joe Perches:
> > On Sat, 2015-03-28 at 21:40 +0100, Richard Weinberger wrote:
> >> On Sat, Mar 28, 2015 at 9:21 PM, Shirish Gajera <gshirishfree@gmail.com> wrote:
> >>> This patch fixes the checkpatch.pl warning:
[]
> >> Instead of blindly adding newlines to silence checkpatch.pl, what
> >> about reworking the code?
> >> printf("%s\n", ..) cries for a puts().
> > 
> > There is no synth_puts
> 
> So what?
> Fix it! :-)

Not sure that'd make the code better... ;-p

> the whole code is horrible and lines other 80 chars are the *least*
> problem.

Dunno about how horrible it is, my guess is it works.

> Submitting a patch just for the sake of silencing checkpatch.pl is a waste of time.
> After applying this patch the driver 0 better than before.

Agree with that.

And truly, checkpatch is only a guide.

Making the code better instead of merely style conforming
should be the primary goal of patches.