From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752377AbbC2X3D (ORCPT ); Sun, 29 Mar 2015 19:29:03 -0400 Received: from smtprelay0224.hostedemail.com ([216.40.44.224]:57216 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750875AbbC2X3A (ORCPT ); Sun, 29 Mar 2015 19:29:00 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2194:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4321:4605:5007:6261:7974:8957:10004:10400:10848:11026:11232:11233:11473:11658:11914:12043:12114:12517:12519:12740:13069:13311:13357:13618:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: cloud24_6b68b3576092f X-Filterd-Recvd-Size: 2316 Message-ID: <1427671736.2715.47.camel@perches.com> Subject: Re: [PATCH 10/11] staging: rtl8192e: Decrease nesting of rtllib_rx_auth_resp() From: Joe Perches To: Mateusz Kulikowski Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Sun, 29 Mar 2015 16:28:56 -0700 In-Reply-To: <551888DE.1050003@gmail.com> References: <1427668867-10906-1-git-send-email-mateusz.kulikowski@gmail.com> <1427668867-10906-11-git-send-email-mateusz.kulikowski@gmail.com> <1427670839.2715.44.camel@perches.com> <551888DE.1050003@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-03-30 at 01:21 +0200, Mateusz Kulikowski wrote: > On 30.03.2015 01:13, Joe Perches wrote: > > On Mon, 2015-03-30 at 00:41 +0200, Mateusz Kulikowski wrote: > >> Return from rtllib_rx_auth_resp() if auth_parse() fails. > >> diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c > > [] > >> + /* Dummy wirless mode setting to avoid > >> + * encryption issue */ > > > > Please use the typical networking comment style > > (and correct the typo too) > > > > /* Dummy wireless mode setting to avoid > > * encryption issue > > */ > > It was like that already - is it ok with you if I fix all the comments (in whole rtl8192e) in separate patch > (I can add it as #12 to v2) ? Of course. > > > >> + if (bSupportNmode) { > >> + ieee->SetWirelessMode(ieee->dev, > >> + ieee->current_network.mode); > >> + } else { > >> + /*TODO*/ > >> + ieee->SetWirelessMode(ieee->dev, > >> + IEEE_G); > > > > Many of these multiple line statements can be single line. > > I wanted to split change of logic and re-indentation; > If you insist - I can merge patches #10 and #11 (#11 does what you ask for) No worries, do what you think appropriate. I think it's appropriate to fix one way or another.