From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752685AbbC3JoI (ORCPT ); Mon, 30 Mar 2015 05:44:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37946 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751398AbbC3JoG (ORCPT ); Mon, 30 Mar 2015 05:44:06 -0400 Message-ID: <1427708644.14176.3.camel@redhat.com> Subject: Re: [PATCH 2/4] [CIFS] Don't ignore errors on encrypting password in SMBTcon From: Sachin Prabhu To: Steve French Cc: linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 30 Mar 2015 10:44:04 +0100 In-Reply-To: <1427434082-4299-3-git-send-email-smfrench@gmail.com> References: <1427434082-4299-1-git-send-email-smfrench@gmail.com> <1427434082-4299-3-git-send-email-smfrench@gmail.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-03-27 at 00:28 -0500, Steve French wrote: > Although unlikely to fail (and tree connect does not commonly send > a password since SECMODE_USER is the default for most servers) > do not ignore errors on SMBNTEncrypt in SMB Tree Connect. > > Reported by Coverity (CID 1226853) > > Signed-off-by: Steve French ACKed-by: Sachin Prabhu > --- > fs/cifs/connect.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c > index 4cb8450..cdb1aaf 100644 > --- a/fs/cifs/connect.c > +++ b/fs/cifs/connect.c > @@ -3696,6 +3696,12 @@ CIFSTCon(const unsigned int xid, struct cifs_ses *ses, > #endif /* CIFS_WEAK_PW_HASH */ > rc = SMBNTencrypt(tcon->password, ses->server->cryptkey, > bcc_ptr, nls_codepage); > + if (rc) { > + cifs_dbg(FYI, "%s Can't generate NTLM rsp. Error: %d\n", > + __func__, rc); > + cifs_buf_release(smb_buffer); > + return rc; > + } > > bcc_ptr += CIFS_AUTH_RESP_SIZE; > if (ses->capabilities & CAP_UNICODE) {