From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, arnd@arndb.de,
mmarek@suse.cz, linux@arm.linux.org.uk
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: [RFC PATCH 2/2] Kbuild: avoid partial linking of drivers/built-in.o
Date: Mon, 30 Mar 2015 13:49:27 +0200 [thread overview]
Message-ID: <1427716167-25078-3-git-send-email-ard.biesheuvel@linaro.org> (raw)
In-Reply-To: <1427716167-25078-1-git-send-email-ard.biesheuvel@linaro.org>
The recursive partial linking of vmlinux can result in a
drivers/built-in.o that is so huge that it interferes with
the ability of the linker to emit veneers in the final link
stage if the symbols are out of reach. This is caused by the
fact that those veneers, which should be emitted close enough
to the original call site, can only be emitted after the .text
section of drivers/built-in.o, whose size pushes those veneers
out of range.
So instead, avoid building drivers/built-in.o, and instead, add
the constituent parts to the command line of the final link.
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
Makefile | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index e734965b1604..1eb6c246a586 100644
--- a/Makefile
+++ b/Makefile
@@ -558,7 +558,7 @@ scripts: scripts_basic include/config/auto.conf include/config/tristate.conf \
# Objects we will link into vmlinux / subdirs we need to visit
init-y := init/
-drivers-y := drivers/ sound/ firmware/
+drivers-y := sound/ firmware/
net-y := net/
libs-y := lib/
core-y := usr/
@@ -569,6 +569,16 @@ ifeq ($(dot-config),1)
-include include/config/auto.conf
ifeq ($(KBUILD_EXTMOD),)
+
+# drivers/built-in.o can become huge, which interferes with the linker's
+# ability to emit stubs for branch targets that are out of reach for the
+# ordinary relative branch instructions
+include $(srctree)/drivers/Makefile
+drivers-y += $(addprefix drivers/,$(sort $(obj-y)))
+drivers-m += $(addprefix drivers/,$(sort $(obj-m)))
+obj-y :=
+obj-m :=
+
# Read in dependencies to all Kconfig* files, make sure to run
# oldconfig if changes are detected.
-include include/config/auto.conf.cmd
--
1.8.3.2
next prev parent reply other threads:[~2015-03-30 11:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 11:49 [RFC PATCH 0/2] ARM large kernels Ard Biesheuvel
2015-03-30 11:49 ` [RFC PATCH 1/2] Kbuild: kallsyms: ignore veneers emitted by the ARM linker Ard Biesheuvel
2015-03-30 12:11 ` Michal Marek
2015-03-30 11:49 ` Ard Biesheuvel [this message]
2015-03-30 12:38 ` [RFC PATCH 2/2] Kbuild: avoid partial linking of drivers/built-in.o Michal Marek
2015-03-30 12:54 ` Ard Biesheuvel
2015-03-30 13:26 ` Russell King - ARM Linux
2015-03-30 13:31 ` Ard Biesheuvel
2015-03-30 14:13 ` Michal Marek
2015-03-30 17:04 ` Ard Biesheuvel
2015-03-31 15:22 ` Nicolas Pitre
2015-03-31 16:27 ` Dave Martin
2015-03-31 16:34 ` Russell King - ARM Linux
2015-03-31 18:46 ` Nicolas Pitre
2015-03-31 18:42 ` Nicolas Pitre
2015-04-01 9:04 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427716167-25078-3-git-send-email-ard.biesheuvel@linaro.org \
--to=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).