From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754061AbbCaCzW (ORCPT ); Mon, 30 Mar 2015 22:55:22 -0400 Received: from gate.crashing.org ([63.228.1.57]:42580 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752725AbbCaCzU (ORCPT ); Mon, 30 Mar 2015 22:55:20 -0400 Message-ID: <1427766549.20500.108.camel@kernel.crashing.org> Subject: Re: [PATCH 06/25] powerpc: Use bool function return values of true/false not 1/0 From: Benjamin Herrenschmidt To: Joe Perches Cc: linux-kernel@vger.kernel.org, Alexander Graf , Gleb Natapov , Paolo Bonzini , Paul Mackerras , Michael Ellerman , linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org Date: Tue, 31 Mar 2015 12:49:09 +1100 In-Reply-To: <6d45a6e4596f0b282048fc4b8db9e7f7a19a46e3.1427759009.git.joe@perches.com> References: <6d45a6e4596f0b282048fc4b8db9e7f7a19a46e3.1427759009.git.joe@perches.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-03-30 at 16:46 -0700, Joe Perches wrote: > Use the normal return values for bool functions Acked-by: Benjamin Herrenschmidt Should we merge it or will you ? Cheers, Ben. > Signed-off-by: Joe Perches > --- > arch/powerpc/include/asm/dcr-native.h | 2 +- > arch/powerpc/include/asm/dma-mapping.h | 4 ++-- > arch/powerpc/include/asm/kvm_book3s_64.h | 4 ++-- > arch/powerpc/sysdev/dcr.c | 2 +- > 4 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/arch/powerpc/include/asm/dcr-native.h b/arch/powerpc/include/asm/dcr-native.h > index 7d2e623..4efc11d 100644 > --- a/arch/powerpc/include/asm/dcr-native.h > +++ b/arch/powerpc/include/asm/dcr-native.h > @@ -31,7 +31,7 @@ typedef struct { > > static inline bool dcr_map_ok_native(dcr_host_native_t host) > { > - return 1; > + return true; > } > > #define dcr_map_native(dev, dcr_n, dcr_c) \ > diff --git a/arch/powerpc/include/asm/dma-mapping.h b/arch/powerpc/include/asm/dma-mapping.h > index 894d538..9103687 100644 > --- a/arch/powerpc/include/asm/dma-mapping.h > +++ b/arch/powerpc/include/asm/dma-mapping.h > @@ -191,11 +191,11 @@ static inline bool dma_capable(struct device *dev, dma_addr_t addr, size_t size) > struct dev_archdata *sd = &dev->archdata; > > if (sd->max_direct_dma_addr && addr + size > sd->max_direct_dma_addr) > - return 0; > + return false; > #endif > > if (!dev->dma_mask) > - return 0; > + return false; > > return addr + size - 1 <= *dev->dma_mask; > } > diff --git a/arch/powerpc/include/asm/kvm_book3s_64.h b/arch/powerpc/include/asm/kvm_book3s_64.h > index 2d81e20..2a244bf 100644 > --- a/arch/powerpc/include/asm/kvm_book3s_64.h > +++ b/arch/powerpc/include/asm/kvm_book3s_64.h > @@ -335,7 +335,7 @@ static inline bool hpte_read_permission(unsigned long pp, unsigned long key) > { > if (key) > return PP_RWRX <= pp && pp <= PP_RXRX; > - return 1; > + return true; > } > > static inline bool hpte_write_permission(unsigned long pp, unsigned long key) > @@ -373,7 +373,7 @@ static inline bool slot_is_aligned(struct kvm_memory_slot *memslot, > unsigned long mask = (pagesize >> PAGE_SHIFT) - 1; > > if (pagesize <= PAGE_SIZE) > - return 1; > + return true; > return !(memslot->base_gfn & mask) && !(memslot->npages & mask); > } > > diff --git a/arch/powerpc/sysdev/dcr.c b/arch/powerpc/sysdev/dcr.c > index 2d8a101..121e26f 100644 > --- a/arch/powerpc/sysdev/dcr.c > +++ b/arch/powerpc/sysdev/dcr.c > @@ -54,7 +54,7 @@ bool dcr_map_ok_generic(dcr_host_t host) > else if (host.type == DCR_HOST_MMIO) > return dcr_map_ok_mmio(host.host.mmio); > else > - return 0; > + return false; > } > EXPORT_SYMBOL_GPL(dcr_map_ok_generic); >