From: Joe Perches <joe@perches.com>
To: "Roger Pau Monné" <roger.pau@citrix.com>
Cc: Tao Chen <boby.chen@huawei.com>,
konrad.wilk@oracle.com, xen-devel@lists.xenproject.org,
linux-kernel@vger.kernel.org, wu.wubin@huawei.com,
rudy.zhangmin@huawei.com
Subject: Re: [PATCH] xen-blkback: define pr_fmt macro to avoid the duplication of DRV_PFX
Date: Tue, 31 Mar 2015 09:53:11 -0700 [thread overview]
Message-ID: <1427820791.10376.24.camel@perches.com> (raw)
In-Reply-To: <551AB5D6.9080009@citrix.com>
On Tue, 2015-03-31 at 16:57 +0200, Roger Pau Monné wrote:
> El 31/03/15 a les 23.14, Tao Chen ha escrit:
> > Define pr_fmt macro with {xen-blkback: } prefix, then remove all use
> > of DRV_PFX in the pr and DPRINTK sentences. It will simplify the code.
[]
> > diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c
[]
> > @@ -14,6 +14,11 @@
> >
> > */
> >
> > +#define pr_fmt(fmt) "xen-blkback: " fmt
> > +#define DPRINTK(fmt, args...) \
> > + pr_debug("(%s:%d) " fmt ".\n", \
> > + __func__, __LINE__, ##args)
As dynamic debug can emit __func__ and __LINE__
I suggest converting DPRINTK to pr_debug.
next prev parent reply other threads:[~2015-03-31 16:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-31 21:14 [PATCH] xen-blkback: define pr_fmt macro to avoid the duplication of DRV_PFX Tao Chen
2015-03-31 14:57 ` Roger Pau Monné
2015-03-31 16:53 ` Joe Perches [this message]
2015-04-01 6:40 ` Chentao (Boby)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427820791.10376.24.camel@perches.com \
--to=joe@perches.com \
--cc=boby.chen@huawei.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roger.pau@citrix.com \
--cc=rudy.zhangmin@huawei.com \
--cc=wu.wubin@huawei.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox