From: Joe Perches <joe@perches.com>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
axboe@kernel.dk, viro@zeniv.linux.org.uk, dm-devel@redhat.com
Subject: Re: [PATCH 1/7] lib/vsprintf: add %*pg format specifier
Date: Tue, 31 Mar 2015 10:37:14 -0700 [thread overview]
Message-ID: <1427823434.10376.33.camel@perches.com> (raw)
In-Reply-To: <1427821576.10376.29.camel@perches.com>
On Tue, 2015-03-31 at 10:06 -0700, Joe Perches wrote:
> On Tue, 2015-03-31 at 20:01 +0400, Dmitry Monakhov wrote:
> > This allow to directly print block_device name.
> > Currently one should use bdevname() with temporal char buf[BDEVNAME_SIZE].
> > This is very ineffective because bloat stack usage for deep IO call-traces
Perhaps it would be useful to update the disk_name/bdevname
functions to take a buffer length along with the char * so
that buffer overflows could not occur.
That would also allow this function to use bdevname directly.
next prev parent reply other threads:[~2015-03-31 17:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-31 16:01 [RFC] [PATCH 0/7] fs: add blkdev name format specifier Dmitry Monakhov
2015-03-31 16:01 ` [PATCH 1/7] lib/vsprintf: add %*pg " Dmitry Monakhov
2015-03-31 17:06 ` Joe Perches
2015-03-31 17:37 ` Joe Perches [this message]
2015-04-01 8:43 ` Dmitry Monakhov
2015-03-31 16:01 ` [PATCH 2/7] fs: use gendisk->disk_name where possible Dmitry Monakhov
2015-03-31 16:01 ` [PATCH 3/7] block: use block_device name vsprintf helper Dmitry Monakhov
2015-03-31 16:01 ` [PATCH 4/7] fs: " Dmitry Monakhov
2015-03-31 16:01 ` [PATCH 5/7] md: " Dmitry Monakhov
2015-03-31 16:01 ` [PATCH 6/7] block/partitions: " Dmitry Monakhov
2015-04-02 5:58 ` Sergey Senozhatsky
2015-03-31 16:01 ` [PATCH 7/7] drivers: " Dmitry Monakhov
2015-03-31 16:43 ` [RFC] [PATCH 0/7] fs: add blkdev name format specifier Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427823434.10376.33.camel@perches.com \
--to=joe@perches.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=dmonakhov@openvz.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox