linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Einon <mark.einon@gmail.com>
To: x86@kernel.org
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org,
	mingo@redhat.com, hpa@zytor.com, stuart.r.anderson@intel.com,
	Mark Einon <mark.einon@gmail.com>
Subject: [PATCH] x86, earlyprintk: Fix two 'defined but not used' compile warnings
Date: Tue, 31 Mar 2015 22:20:12 +0100	[thread overview]
Message-ID: <1427836812-7968-1-git-send-email-mark.einon@gmail.com> (raw)

Two static functions are only used if CONFIG_PCI is defined,so only build them
if this is the case. Fixes the build warnings:

arch/x86/kernel/early_printk.c:98:13: warning: ‘mem32_serial_out’ defined but not used [-Wunused-function]
 static void mem32_serial_out(unsigned long addr, int offset, int value)
             ^
arch/x86/kernel/early_printk.c:105:21: warning: ‘mem32_serial_in’ defined but not used [-Wunused-function]
 static unsigned int mem32_serial_in(unsigned long addr, int offset)
                     ^
Signed-off-by: Mark Einon <mark.einon@gmail.com>
---
 arch/x86/kernel/early_printk.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/x86/kernel/early_printk.c b/arch/x86/kernel/early_printk.c
index f85e3fb..6a69625 100644
--- a/arch/x86/kernel/early_printk.c
+++ b/arch/x86/kernel/early_printk.c
@@ -95,6 +95,7 @@ static unsigned long early_serial_base = 0x3f8;  /* ttyS0 */
 #define DLL             0       /*  Divisor Latch Low         */
 #define DLH             1       /*  Divisor latch High        */
 
+#ifdef CONFIG_PCI
 static void mem32_serial_out(unsigned long addr, int offset, int value)
 {
 	uint32_t *vaddr = (uint32_t *)addr;
@@ -108,6 +109,7 @@ static unsigned int mem32_serial_in(unsigned long addr, int offset)
 	/* shift implied by pointer type */
 	return readl(vaddr + offset);
 }
+#endif
 
 static unsigned int io_serial_in(unsigned long addr, int offset)
 {
-- 
2.1.4


             reply	other threads:[~2015-03-31 21:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-31 21:20 Mark Einon [this message]
2015-03-31 21:45 ` [PATCH] x86, earlyprintk: Fix two 'defined but not used' compile warnings Borislav Petkov
2015-03-31 22:07 ` [PATCH v2] " Mark Einon
2015-04-01  7:54   ` Ingo Molnar
2015-04-01  8:05     ` Mark Einon
2015-04-01 21:32   ` [PATCH v3] " Mark Einon
2015-04-02  4:35     ` Borislav Petkov
2015-04-03 14:06     ` [tip:x86/cleanups] x86/earlyprintk: Put CONFIG_PCI-only functions under the #ifdef tip-bot for Mark Einon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427836812-7968-1-git-send-email-mark.einon@gmail.com \
    --to=mark.einon@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=stuart.r.anderson@intel.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).