From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752497AbbDAApj (ORCPT ); Tue, 31 Mar 2015 20:45:39 -0400 Received: from mail-pd0-f177.google.com ([209.85.192.177]:33787 "EHLO mail-pd0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752046AbbDAApi (ORCPT ); Tue, 31 Mar 2015 20:45:38 -0400 Message-ID: <1427849133.5305.1.camel@phoenix> Subject: [PATCH v2 2/2] phy: spear1340-miphy: Return proper error for spear1340_miphy_xlate From: Axel Lin To: Kishon Vijay Abraham I Cc: Peter Griffin , "linux-kernel@vger.kernel.org" Date: Wed, 01 Apr 2015 08:45:33 +0800 In-Reply-To: <1427849072.5305.0.camel@phoenix> References: <1427849072.5305.0.camel@phoenix> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The of_xlate callback should return ERR_PTR on error. Signed-off-by: Axel Lin --- v2: Return -ENODEV instead of -EINVAL so that phy_optional_get() doesn't fail. drivers/phy/phy-spear1340-miphy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/phy/phy-spear1340-miphy.c b/drivers/phy/phy-spear1340-miphy.c index e42bc20..210979b 100644 --- a/drivers/phy/phy-spear1340-miphy.c +++ b/drivers/phy/phy-spear1340-miphy.c @@ -229,14 +229,14 @@ static struct phy *spear1340_miphy_xlate(struct device *dev, if (args->args_count < 1) { dev_err(dev, "DT did not pass correct no of args\n"); - return NULL; + return ERR_PTR(-ENODEV); } priv->mode = args->args[0]; if (priv->mode != SATA && priv->mode != PCIE) { dev_err(dev, "DT did not pass correct phy mode\n"); - return NULL; + return ERR_PTR(-ENODEV); } return priv->phy; -- 1.9.1