From: Joe Perches <joe@perches.com>
To: Andrew Bresticker <abrestic@chromium.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Ralf Baechle <ralf@linux-mips.org>,
devicetree@vger.kernel.org, linux-mips@linux-mips.org,
linux-kernel@vger.kernel.org,
James Hartley <james.hartley@imgtec.com>,
Damien Horsley <Damien.Horsley@imgtec.com>
Subject: Re: [PATCH 2/2] phy: Add driver for Pistachio USB2.0 PHY
Date: Wed, 01 Apr 2015 13:38:48 -0700 [thread overview]
Message-ID: <1427920728.31790.94.camel@perches.com> (raw)
In-Reply-To: <1427919394-3580-3-git-send-email-abrestic@chromium.org>
On Wed, 2015-04-01 at 13:16 -0700, Andrew Bresticker wrote:
> Add a driver for the USB2.0 PHY found on the IMG Pistachio SoC.
Spelling trivia:
> diff --git a/drivers/phy/phy-pistachio-usb.c b/drivers/phy/phy-pistachio-usb.c
[]
> +static int pistachio_usb_phy_power_on(struct phy *phy)
> +{
[]
> + if (p_phy->refclk == REFCLK_XO_CRYSTAL && rate != 12000000) {
> + dev_err(p_phy->dev, "Unspported rate for XO crystal: %ld\n",
typo
[]
> + if (i == ARRAY_SIZE(fsel_rate_map)) {
> + dev_err(p_phy->dev, "Unspported clock rate: %lu\n", rate);
here too
prev parent reply other threads:[~2015-04-01 20:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-01 20:16 [PATCH 0/2] Pistachio USB2.0 PHY Andrew Bresticker
2015-04-01 20:16 ` [PATCH 1/2] phy: Add binding document for " Andrew Bresticker
2015-04-01 20:16 ` [PATCH 2/2] phy: Add driver " Andrew Bresticker
2015-04-01 20:38 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427920728.31790.94.camel@perches.com \
--to=joe@perches.com \
--cc=Damien.Horsley@imgtec.com \
--cc=abrestic@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=james.hartley@imgtec.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox