From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932100AbbDAUiz (ORCPT ); Wed, 1 Apr 2015 16:38:55 -0400 Received: from smtprelay0179.hostedemail.com ([216.40.44.179]:44445 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932077AbbDAUix (ORCPT ); Wed, 1 Apr 2015 16:38:53 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1568:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3865:4250:4321:5007:6119:6261:7903:10004:10400:10848:11026:11232:11473:11658:11914:12043:12438:12517:12519:12555:12740:13069:13311:13357:21080:21088,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: steam65_6a501fba9c153 X-Filterd-Recvd-Size: 1655 Message-ID: <1427920728.31790.94.camel@perches.com> Subject: Re: [PATCH 2/2] phy: Add driver for Pistachio USB2.0 PHY From: Joe Perches To: Andrew Bresticker Cc: Kishon Vijay Abraham I , Ralf Baechle , devicetree@vger.kernel.org, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, James Hartley , Damien Horsley Date: Wed, 01 Apr 2015 13:38:48 -0700 In-Reply-To: <1427919394-3580-3-git-send-email-abrestic@chromium.org> References: <1427919394-3580-1-git-send-email-abrestic@chromium.org> <1427919394-3580-3-git-send-email-abrestic@chromium.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-04-01 at 13:16 -0700, Andrew Bresticker wrote: > Add a driver for the USB2.0 PHY found on the IMG Pistachio SoC. Spelling trivia: > diff --git a/drivers/phy/phy-pistachio-usb.c b/drivers/phy/phy-pistachio-usb.c [] > +static int pistachio_usb_phy_power_on(struct phy *phy) > +{ [] > + if (p_phy->refclk == REFCLK_XO_CRYSTAL && rate != 12000000) { > + dev_err(p_phy->dev, "Unspported rate for XO crystal: %ld\n", typo [] > + if (i == ARRAY_SIZE(fsel_rate_map)) { > + dev_err(p_phy->dev, "Unspported clock rate: %lu\n", rate); here too