From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753110AbbDDVGW (ORCPT ); Sat, 4 Apr 2015 17:06:22 -0400 Received: from mga03.intel.com ([134.134.136.65]:31429 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753068AbbDDVGT (ORCPT ); Sat, 4 Apr 2015 17:06:19 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,524,1422950400"; d="scan'208";a="675328627" Message-ID: <1428181575.2610.31.camel@picadillo> Subject: Re: [PATCH v3 5/7] tracing: Add 'hist' event trigger command From: Tom Zanussi To: Paul Bolle Cc: rostedt@goodmis.org, masami.hiramatsu.pt@hitachi.com, namhyung@kernel.org, andi@firstfloor.org, linux-kernel@vger.kernel.org Date: Sat, 04 Apr 2015 16:06:15 -0500 In-Reply-To: <1428180979.2368.5.camel@tiscali.nl> References: <9fe50519aa2cac1550b40a0e396dd721eff03574.1428072891.git.tom.zanussi@linux.intel.com> <1428160496.7898.132.camel@x220> <1428178145.2610.13.camel@picadillo> <1428180979.2368.5.camel@tiscali.nl> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2015-04-04 at 22:56 +0200, Paul Bolle wrote: > Tom Zanussi schreef op za 04-04-2015 om 15:09 [-0500]: > > [PATCH] kallsyms: Include module.h > > > > KSYM_SYMBOL_LEN references MODULE_NAME_LEN, defined in module.h, so > > have kallsyms.h include module.h instead of expecting kallsysms users > > to do it. > > > > Also fix up existing kallsyms users that apparently include module.h > > for only that reason. > > > > Signed-off-by: Tom Zanussi > > --- > > include/linux/ftrace.h | 1 - > > include/linux/kallsyms.h | 1 + > > kernel/trace/trace_events_hist.c | 2 +- > > kernel/trace/trace_kprobe.c | 1 + > > kernel/trace/trace_output.c | 1 + > > kernel/trace/trace_syscalls.c | 2 +- > > 6 files changed, 5 insertions(+), 3 deletions(-) > > > > diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h > > index 1da6029..8554dd5 100644 > > --- a/include/linux/ftrace.h > > +++ b/include/linux/ftrace.h > > @@ -7,7 +7,6 @@ > > #define _LINUX_FTRACE_H > > > > #include > > -#include > > #include > > #include > > #include > > The commit explanation is silent about this change. Are you sure you > want to include it? > Probably, but I'll mention in the changelog. I'll submit a complete patch with my updated patchset (after looking around for other includes of module.h to add). > > diff --git a/include/linux/kallsyms.h b/include/linux/kallsyms.h > > index 6883e19..e1550a4 100644 > > --- a/include/linux/kallsyms.h > > +++ b/include/linux/kallsyms.h > > @@ -8,6 +8,7 @@ > > #include > > #include > > #include > > +#include > > > > #define KSYM_NAME_LEN 128 > > #define KSYM_SYMBOL_LEN (sizeof("%s+%#lx/%#lx [%s]") + (KSYM_NAME_LEN - 1) + \ > > diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c > > index 3d648ee..c290379 100644 > > --- a/kernel/trace/trace_events_hist.c > > +++ b/kernel/trace/trace_events_hist.c > > @@ -20,7 +20,7 @@ > > * http://www.azulsystems.com/events/javaone_2007/2007_LockFreeHash.pdf > > */ > > > > -#include > > +#include > > #include > > #include > > #include > > diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c > > index 9ba3f43..39019ec 100644 > > --- a/kernel/trace/trace_kprobe.c > > +++ b/kernel/trace/trace_kprobe.c > > @@ -19,6 +19,7 @@ > > > > #include > > Note to self: needed for "struct module". But this file has two > references to THIS_MODULE that look useless. > > > #include > > +#include > > > > #include "trace_probe.h" > > > > diff --git a/kernel/trace/trace_output.c b/kernel/trace/trace_output.c > > index 692bf71..5ec310e 100644 > > --- a/kernel/trace/trace_output.c > > +++ b/kernel/trace/trace_output.c > > @@ -8,6 +8,7 @@ > > #include > > Can't this be dropped too? > Yeah, of course that's the whole point, which I missed here ;-) Tom > > #include > > #include > > +#include > > > > #include "trace_output.h" > > > > diff --git a/kernel/trace/trace_syscalls.c b/kernel/trace/trace_syscalls.c > > index d137e0a..72af617 100644 > > --- a/kernel/trace/trace_syscalls.c > > +++ b/kernel/trace/trace_syscalls.c > > @@ -3,7 +3,7 @@ > > #include > > #include > > #include > > -#include /* for MODULE_NAME_LEN via KSYM_SYMBOL_LEN */ > > +#include > > #include > > #include > > #include > > Thanks, > > > Paul Bolle >