From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752864AbbDEVQn (ORCPT ); Sun, 5 Apr 2015 17:16:43 -0400 Received: from mail-wg0-f41.google.com ([74.125.82.41]:33555 "EHLO mail-wg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752779AbbDEVQ1 (ORCPT ); Sun, 5 Apr 2015 17:16:27 -0400 From: Giedrius Statkevicius To: lidza.louina@gmail.com, markh@compro.net Cc: gregkh@linuxfoundation.org, driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Giedrius=20Statkevi=C4=8Dius?= Subject: [PATCH 3/3] staging: dgnc: improve the coding style in unlocking part of dgnc_tty_write() Date: Mon, 6 Apr 2015 00:15:55 +0300 Message-Id: <1428268555-8963-3-git-send-email-giedrius.statkevicius@gmail.com> X-Mailer: git-send-email 2.3.5 In-Reply-To: <1428268555-8963-1-git-send-email-giedrius.statkevicius@gmail.com> References: <1428268555-8963-1-git-send-email-giedrius.statkevicius@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org do if (blah) foo(); bar(); instead of if (blah) { foo(); bar(); } else { bar(); } Signed-off-by: Giedrius Statkevičius --- drivers/staging/dgnc/dgnc_tty.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c index 651a925..c59a784 100644 --- a/drivers/staging/dgnc/dgnc_tty.c +++ b/drivers/staging/dgnc/dgnc_tty.c @@ -1843,12 +1843,10 @@ static int dgnc_tty_write(struct tty_struct *tty, ch->ch_cpstime += (HZ * count) / ch->ch_digi.digi_maxcps; } - if (from_user) { - spin_unlock_irqrestore(&ch->ch_lock, flags); + if (from_user) mutex_unlock(&dgnc_TmpWriteSem); - } else { - spin_unlock_irqrestore(&ch->ch_lock, flags); - } + + spin_unlock_irqrestore(&ch->ch_lock, flags); if (count) { /* -- 2.3.5