From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753139AbbDFSHy (ORCPT ); Mon, 6 Apr 2015 14:07:54 -0400 Received: from lb2-smtp-cloud6.xs4all.net ([194.109.24.28]:60915 "EHLO lb2-smtp-cloud6.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752770AbbDFSHq (ORCPT ); Mon, 6 Apr 2015 14:07:46 -0400 Message-ID: <1428343660.634.146.camel@x220> Subject: Re: [PATCH v3 5/7] tracing: Add 'hist' event trigger command From: Paul Bolle To: Steven Rostedt Cc: Tom Zanussi , masami.hiramatsu.pt@hitachi.com, namhyung@kernel.org, andi@firstfloor.org, linux-kernel@vger.kernel.org Date: Mon, 06 Apr 2015 20:07:40 +0200 In-Reply-To: <20150406122551.6e9ab8bc@gandalf.local.home> References: <9fe50519aa2cac1550b40a0e396dd721eff03574.1428072891.git.tom.zanussi@linux.intel.com> <1428160496.7898.132.camel@x220> <20150406115012.179e3fa6@gandalf.local.home> <1428337159.634.132.camel@x220> <20150406122551.6e9ab8bc@gandalf.local.home> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-04-06 at 12:25 -0400, Steven Rostedt wrote: > On Mon, 06 Apr 2015 18:19:19 +0200 > Paul Bolle wrote: > I hope you don't think I was mocking you. I wasn't. No, I didn't think you were. > The only issue I can think of that including an unneeded header file > does is to make the compile slightly longer. It's not a major need to > do, but it may be done. This entire conversation was triggered by . It has turned into a bit of a red flag for me. That is, if I see a patch adding an include of that header while the code it adds is built-in only, I have a reason to stare at that patch just a little bit longer. Because there's a chance that the code is meant to be modular instead of built-in only or that it contains a few things that are irrelevant for built-in code. It just happened that things turned out to be rather complicated when I stared at Tom's patch just a little bit longer. Thanks, Paul Bolle